Fix internal error from CollateExpr in SQL/JSON DEFAULT expressions
authorAmit Langote <[email protected]>
Thu, 9 Oct 2025 05:07:36 +0000 (01:07 -0400)
committerAmit Langote <[email protected]>
Thu, 9 Oct 2025 05:07:36 +0000 (01:07 -0400)
commit09f86a42f25cd32d8d268484252671341033b2c0
tree6ba9757cda94f4c39754a5006732c12ac2fedb70
parent1c4671f7b7c378cc26d1953785a3aa249152958b
Fix internal error from CollateExpr in SQL/JSON DEFAULT expressions

SQL/JSON functions such as JSON_VALUE could fail with "unrecognized
node type" errors when a DEFAULT clause contained an explicit COLLATE
expression. That happened because assign_collations_walker() could
invoke exprSetCollation() on a JsonBehavior expression whose DEFAULT
still contained a CollateExpr, which exprSetCollation() does not
handle.

For example:

  SELECT JSON_VALUE('{"a":1}', '$.c' RETURNING text
                    DEFAULT 'A' COLLATE "C" ON EMPTY);

Fix by validating in transformJsonBehavior() that the DEFAULT
expression's collation matches the enclosing JSON expression’s
collation. In exprSetCollation(), replace the recursive call on the
JsonBehavior expression with an assertion that its collation already
matches the target, since the parser now enforces that condition.

Reported-by: Jian He <[email protected]>
Author: Jian He <[email protected]>
Reviewed-by: Amit Langote <[email protected]>
Discussion: https://postgr.es/m/CACJufxHVwYYSyiVQ6o+PsRX6zQ7rAFinh_fv1kCfTsT1xG4Zeg@mail.gmail.com
Backpatch-through: 17
src/backend/nodes/nodeFuncs.c
src/backend/parser/parse_expr.c
src/test/regress/expected/collate.icu.utf8.out
src/test/regress/sql/collate.icu.utf8.sql