Reduce risks of conflicts in internal queries of REFRESH MATVIEW CONCURRENTLY
authorMichael Paquier <[email protected]>
Thu, 3 Jun 2021 06:28:24 +0000 (15:28 +0900)
committerMichael Paquier <[email protected]>
Thu, 3 Jun 2021 06:28:24 +0000 (15:28 +0900)
commit187682c3217375c9b70417bf3235790f639e8e7e
tree86f9754834affc2b0bf72c02c9ab9323fa56bcfa
parentcb3cffe694b6041c1de47b12b225e05f664c7285
Reduce risks of conflicts in internal queries of REFRESH MATVIEW CONCURRENTLY

The internal SQL queries used by REFRESH MATERIALIZED VIEW CONCURRENTLY
include some aliases for its diff and temporary relations with
rather-generic names: diff, newdata, newdata2 and mv.  Depending on the
queries used for the materialized view, using CONCURRENTLY could lead to
some internal failures if the matview query and those internal aliases
conflict.

Those names have been chosen in 841c29c8.  This commit switches instead
to a naming pattern which is less likely going to cause conflicts, based
on an idea from Thomas Munro, by appending _$ to those aliases.  This is
not perfect as those new names could still conflict, but at least it has
the advantage to keep the code readable and simple while reducing the
likelihood of conflicts to be close to zero.

Reported-by: Mathis Rudolf
Author: Bharath Rupireddy
Reviewed-by: Bernd Helmle, Thomas Munro, Michael Paquier
Discussion: https://postgr.es/m/109c267a-10d2-3c53-b60e-720fcf44d9e8@credativ.de
Backpatch-through: 9.6
src/backend/commands/matview.c