Fix privilege checks for pg_prewarm() on indexes.
authorNathan Bossart <[email protected]>
Fri, 17 Oct 2025 16:36:50 +0000 (11:36 -0500)
committerNathan Bossart <[email protected]>
Fri, 17 Oct 2025 16:36:50 +0000 (11:36 -0500)
commit19a64f5676bb51a3c01891c4bdb184ae48944936
tree48bc957c2e9d4f4c919cdb98bd146646dd1b2a9a
parentf768f5a7d408c7a5efe45d49136818f7d4d0a62a
Fix privilege checks for pg_prewarm() on indexes.

pg_prewarm() currently checks for SELECT privileges on the target
relation.  However, indexes do not have access rights of their own,
so a role may be denied permission to prewarm an index despite
having the SELECT privilege on its parent table.  This commit fixes
this by locking the parent table before the index (to avoid
deadlocks) and checking for SELECT on the parent table.  Note that
the code is largely borrowed from
amcheck_lock_relation_and_check().

An obvious downside of this change is the extra AccessShareLock on
the parent table during prewarming, but that isn't expected to
cause too much trouble in practice.

Author: Ayush Vatsa <[email protected]>
Co-authored-by: Nathan Bossart <[email protected]>
Reviewed-by: Tom Lane <[email protected]>
Reviewed-by: Jeff Davis <[email protected]>
Discussion: https://postgr.es/m/CACX%2BKaMz2ZoOojh0nQ6QNBYx8Ak1Dkoko%3DD4FSb80BYW%2Bo8CHQ%40mail.gmail.com
Backpatch-through: 13
contrib/pg_prewarm/pg_prewarm.c