Drop unnamed portal immediately after execution to completion
authorMichael Paquier <[email protected]>
Wed, 5 Nov 2025 05:35:16 +0000 (14:35 +0900)
committerMichael Paquier <[email protected]>
Wed, 5 Nov 2025 05:35:16 +0000 (14:35 +0900)
commit1fd981f05369340a8afa4d013a350b0b2ac6e33e
tree762d242a953595194d39ab31d1987cbb00cf3bf6
parent59dec6c0b09f717e4ce78d54f578d56ef93bcc53
Drop unnamed portal immediately after execution to completion

Previously, unnamed portals were kept until the next Bind message or the
end of the transaction.  This could cause temporary files to persist
longer than expected and make logging not reflect the actual SQL
responsible for the temporary file.

This patch changes exec_execute_message() to drop unnamed portals
immediately after execution to completion at the end of an Execute
message, making their removal more aggressive.  This forces temporary
file cleanups to happen at the same time as the completion of the portal
execution, with statement logging correctly reflecting to which
statements these temporary files were attached to (see the diffs in the
TAP test updated by this commit for an idea).

The documentation is updated to describe the lifetime of unnamed
portals, and test cases are updated to verify temporary file removal and
proper statement logging after unnamed portal execution.  This changes
how unnamed portals are handled in the protocol, hence no backpatch is
done.

Author: Frédéric Yhuel <[email protected]>
Co-Authored-by: Sami Imseih <[email protected]>
Co-Authored-by: Mircea Cadariu <[email protected]>
Discussion: https://postgr.es/m/CAA5RZ0tTrTUoEr3kDXCuKsvqYGq8OOHiBwoD-dyJocq95uEOTQ%40mail.gmail.com
doc/src/sgml/protocol.sgml
src/backend/tcop/postgres.c
src/test/modules/test_misc/t/009_log_temp_files.pl