Fix assertion failure and segmentation fault in backup code.
authorFujii Masao <[email protected]>
Tue, 12 Jul 2022 02:53:29 +0000 (11:53 +0900)
committerFujii Masao <[email protected]>
Wed, 20 Jul 2022 00:54:24 +0000 (09:54 +0900)
commit2497d2b770916f802353f3bf5e03d42c4c98d3cf
tree8c291f9a8629b9de903862f1ec5f8282c9c5953f
parentdd831afc44bf77dd1fd8095d684153bbf5544e1c
Fix assertion failure and segmentation fault in backup code.

When a non-exclusive backup is canceled, do_pg_abort_backup() is called
and resets some variables set by pg_backup_start (pg_start_backup in v14
or before). But previously it forgot to reset the session state indicating
whether a non-exclusive backup is in progress or not in this session.

This issue could cause an assertion failure when the session running
BASE_BACKUP is terminated after it executed pg_backup_start and
pg_backup_stop (pg_stop_backup in v14 or before). Also it could cause
a segmentation fault when pg_backup_stop is called after BASE_BACKUP
in the same session is canceled.

This commit fixes the issue by making do_pg_abort_backup reset
that session state.

Back-patch to all supported branches.

Author: Fujii Masao
Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Michael Paquier, Robert Haas
Discussion: https://postgr.es/m/3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com
src/backend/access/transam/xlog.c