Make test_target_session_attrs more robust against connection failure.
authorTom Lane <[email protected]>
Wed, 3 Mar 2021 18:51:43 +0000 (13:51 -0500)
committerTom Lane <[email protected]>
Wed, 3 Mar 2021 18:51:43 +0000 (13:51 -0500)
commit3769e11a31831fc2f3bd4c4a24b4f45c352fb8fb
tree159781076e54f6344348e8b6265681ac7b07a7f2
parentf06b1c598254f8adb2b7f51d6a7685618a7fb121
Make test_target_session_attrs more robust against connection failure.

Feed the desired command to psql via "-c" not stdin, else Perl
may complain that it can't push stdin to an already-failed psql
process, as seen in intermittent buildfarm failures.

Make some minor cosmetic improvements while at it.

Before commit ee28cacf6 we had no tests here that expected failure
to connect, so there seems no need for a back-patch.

Discussion: https://postgr.es/m/CALDaNm2mo8YED=M2ZJKGf1U3F3mw6SaQuLXWCK8rZP6sECYcrA@mail.gmail.com
src/test/recovery/t/001_stream_rep.pl