pgbench: Fix assertion failure with multiple \syncpipeline in pipeline mode.
authorFujii Masao <[email protected]>
Fri, 14 Nov 2025 13:40:39 +0000 (22:40 +0900)
committerFujii Masao <[email protected]>
Fri, 14 Nov 2025 13:40:39 +0000 (22:40 +0900)
commit4aa0ac05765edf6b5f0c13e18ac677287ce78206
tree20c970e0f9d7c0fb110ed729a92920544aa017e8
parente4018f891dec09ff95ac97e5b1a2307349aeeffa
pgbench: Fix assertion failure with multiple \syncpipeline in pipeline mode.

Previously, when pgbench ran a custom script that triggered retriable errors
(e.g., deadlocks) followed by multiple \syncpipeline commands in pipeline mode,
the following assertion failure could occur:

    Assertion failed: (res == ((void*)0)), function discardUntilSync, file pgbench.c, line 3594.

The issue was that discardUntilSync() assumed a pipeline sync result
(PGRES_PIPELINE_SYNC) would always be followed by either another sync result
or NULL. This assumption was incorrect: when multiple sync requests were sent,
a sync result could instead be followed by another result type. In such cases,
discardUntilSync() mishandled the results, leading to the assertion failure.

This commit fixes the issue by making discardUntilSync() correctly handle cases
where a pipeline sync result is followed by other result types. It now continues
discarding results until another pipeline sync followed by NULL is reached.

Backpatched to v17, where support for \syncpipeline command in pgbench was
introduced.

Author: Yugo Nagata <[email protected]>
Reviewed-by: Chao Li <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/20251111105037.f3fc554616bc19891f926c5b@sraoss.co.jp
Backpatch-through: 17
src/bin/pgbench/pgbench.c