Fix creation of partition descriptor during concurrent detach
authorAlvaro Herrera <[email protected]>
Tue, 11 Jun 2024 09:38:45 +0000 (11:38 +0200)
committerAlvaro Herrera <[email protected]>
Tue, 11 Jun 2024 09:38:45 +0000 (11:38 +0200)
commit5dcaefc6a0cf35e3afed0a38216a463d736fff5b
tree99e85b1c211b39446bcf2038622b327e8d71a4cd
parent5f200ab5749a0813c48b45b217b273abeb2fdc52
Fix creation of partition descriptor during concurrent detach

When a partition is being detached in concurrent mode, it is possible
for find_inheritance_children_extended() to return that partition in the
list, and immediately after that receive an invalidation message that
sets its relpartbound to NULL just before we read it.  (This can happen
because table_open() reads invalidation messages.)  Currently we raise
an error
  ERROR:  missing relpartbound for relation %u
about the situation, but that's bogus because the table is no longer a
partition, so we shouldn't be complaining about it.  A better reaction
is to retry the find_inheritance_children_extended call to get a new
list, which will no longer have the partition being detached.

Noticed while investigating bug #18377.

Backpatch to 14, where DETACH CONCURRENTLY appeared.

Discussion: https://postgr.es/m/202405201616[email protected]
src/backend/partitioning/partdesc.c