Don't add bailout adjustment for non-strict deserialize calls.
authorAndrew Gierth <[email protected]>
Thu, 28 Jan 2021 10:53:10 +0000 (10:53 +0000)
committerAndrew Gierth <[email protected]>
Thu, 28 Jan 2021 10:53:10 +0000 (10:53 +0000)
commita3367aa3c4552170004c92369681730d85e384c6
tree3e307e8a457b86940fdf6a280157bb774089affa
parentbca96ddab57c7c64ce442b0f9f35558741c7f8bd
Don't add bailout adjustment for non-strict deserialize calls.

When building aggregate expression steps, strict checks need a bailout
jump for when a null value is encountered, so there is a list of steps
that require later adjustment. Adding entries to that list for steps
that aren't actually strict would be harmless, except that there is an
Assert which catches them. This leads to spurious errors on asserts
builds, for data sets that trigger parallel aggregation of an
aggregate with a non-strict deserialization function (no such
aggregates exist in the core system).

Repair by not adding the adjustment entry when it's not needed.

Backpatch back to 11 where the code was introduced.

Per a report from Darafei (Komzpa) of the PostGIS project; analysis
and patch by me.

Discussion: https://postgr.es/m/[email protected]
src/backend/executor/execExpr.c