Remove overzealous _bt_killitems assertion.
authorPeter Geoghegan <[email protected]>
Fri, 10 Oct 2025 18:52:21 +0000 (14:52 -0400)
committerPeter Geoghegan <[email protected]>
Fri, 10 Oct 2025 18:52:21 +0000 (14:52 -0400)
commitae15cebc2035b77626e7d55757324b429c5e1f38
tree9b387544d3fcf01ae846222329f4b5e58a6fd070
parentede2f6b893219296d953177de11df4f43a593e81
Remove overzealous _bt_killitems assertion.

An assertion in _bt_killitems expected the scan's currPos state to
contain a valid LSN, saved from when currPos's page was initially read.
The assertion failed to account for the fact that even logged relations
can have leaf pages with an invalid LSN when built with wal_level set to
"minimal".  Remove the faulty assertion.

Oversight in commit e6eed40e (though note that the assertion was
backpatched to stable branches before 18 by commit 7c319f54).

Author: Peter Geoghegan <[email protected]>
Reported-By: Matthijs van der Vleuten <[email protected]>
Bug: #19082
Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
Backpatch-through: 13
src/backend/access/nbtree/nbtutils.c