Fix oldest xmin and LSN computation across repslots after advancing
authorMichael Paquier <[email protected]>
Thu, 18 Jun 2020 07:34:59 +0000 (16:34 +0900)
committerMichael Paquier <[email protected]>
Thu, 18 Jun 2020 07:34:59 +0000 (16:34 +0900)
commitb48df818dcbd1a5e34ab7a2d9f98828b7b62140c
treead39835ec51f2a4812b9864c637a86bbae3f3018
parent0a40563eadc67472d6fd50dabf7002afa25c3330
Fix oldest xmin and LSN computation across repslots after advancing

Advancing a replication slot did not recompute the oldest xmin and LSN
values across replication slots, preventing resource removal like
segments not recycled at checkpoint time.  The original commit that
introduced the slot advancing in 9c7d06d never did the update of those
oldest values, and b0afdca removed this code.

This commit adds a TAP test to check segment recycling with advancing
for physical slots, enforcing an extra segment switch before advancing
to check if the segment gets correctly recycled after a checkpoint.

Reported-by: Andres Freund
Reviewed-by: Alexey Kondratov, Kyptaro Horiguchi
Discussion: https://postgr.es/m/20200609171904[email protected]
Backpatch-through: 11
src/backend/replication/slotfuncs.c
src/test/recovery/t/001_stream_rep.pl