Fix test_decoding's handling of nonexistant columns in old tuple versions.
authorAndres Freund <[email protected]>
Sat, 27 Jun 2015 16:49:00 +0000 (18:49 +0200)
committerAndres Freund <[email protected]>
Sat, 27 Jun 2015 17:01:00 +0000 (19:01 +0200)
commited6c8d73619a69c8751c8662242fdce22d31bc42
tree39353be38045ccef6be4df8b37b323b283fef76c
parent524e1e40316afc3cf8ba70910fefe1f99b18144f
Fix test_decoding's handling of nonexistant columns in old tuple versions.

test_decoding used fastgetattr() to extract column values. That's wrong
when decoding updates and deletes if a table's replica identity is set
to FULL and new columns have been added since the old version of the
tuple was created. Due to the lack of a crosscheck with the datum's
natts values an invalid value will be output, leading to errors or
worse.

Bug: #13470
Reported-By: Krzysztof Kotlarski
Discussion: 20150626100333[email protected]

Backpatch to 9.4, where the feature, including the bug, was added.
contrib/test_decoding/expected/ddl.out
contrib/test_decoding/sql/ddl.sql
contrib/test_decoding/test_decoding.c