Place "extern" declaration in the right part of pg_class.h.

errdetail_relkind_not_supported() was declared within
EXPOSE_TO_CLIENT_CODE, which is mistaken since that function
isn't available client-side.  While relatively harmless,
this isn't good precedent.

Discussion: https://postgr.es/m/1134562.1742507765@sss.pgh.pa.us

diff --git a/src/include/catalog/pg_class.h b/src/include/catalog/pg_class.h
index fa96ba07bf495e3f1a88a9e6ee84e6e7a404c575..07d182da796a0c798d0ded6d97b61671d37ac491 100644 (file)
--- a/src/include/catalog/pg_class.h
+++ b/src/include/catalog/pg_class.h
@@ -231,8 +231,8 @@ MAKE_SYSCACHE(RELNAMENSP, pg_class_relname_nsp_index, 128);
     (relkind) == RELKIND_TOASTVALUE || \
     (relkind) == RELKIND_MATVIEW)
 
-extern int errdetail_relkind_not_supported(char relkind);
-
 #endif                         /* EXPOSE_TO_CLIENT_CODE */
 
+extern int errdetail_relkind_not_supported(char relkind);
+
 #endif                         /* PG_CLASS_H */