Use more appropriate DatumGet* function

Use DatumGetCString() instead of DatumGetPointer() for returning a C
string.  Right now, they are the same, but that doesn't always have to
be so.

Reviewed-by: Chao Li <[email protected]>
Reviewed-by: Bertrand Drouvot <[email protected]>
Discussion: https://www.postgresql.org/message-id/4154950a-47ae-4223-bd01-1235cc50e933%40eisentraut.org

diff --git a/src/test/modules/test_resowner/test_resowner_basic.c b/src/test/modules/test_resowner/test_resowner_basic.c
index 8f7949963719fcb0d3f3afdca78cb30ae5ebf8b9..b84ec2cb2997849ab20d350b1343998357927503 100644 (file)
--- a/src/test/modules/test_resowner/test_resowner_basic.c
+++ b/src/test/modules/test_resowner/test_resowner_basic.c
@@ -35,13 +35,13 @@ static const ResourceOwnerDesc string_desc = {
 static void
 ReleaseString(Datum res)
 {
-   elog(NOTICE, "releasing string: %s", DatumGetPointer(res));
+   elog(NOTICE, "releasing string: %s", DatumGetCString(res));
 }
 
 static char *
 PrintString(Datum res)
 {
-   return psprintf("test string \"%s\"", DatumGetPointer(res));
+   return psprintf("test string \"%s\"", DatumGetCString(res));
 }
 
 /* demonstrates phases and priorities between a parent and child context */