Fix snapshot handling bug in recent BRIN fix

Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing
work-items (BRIN autosummarization), but forgot to handle the case of
a transaction failing during the run, which drops the snapshot untimely.
Fix by making the pop conditional on an element being actually there.

Author: Álvaro Herrera <[email protected]>
Backpatch-through: 13
Discussion: https://postgr.es/m/202511041648[email protected]

diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
index 2d10ee223771ebd2ba6aa7f4dd4f15062ee70d75..183319c4b1cf735394aad798ab25f06b30dd07b5 100644 (file)
--- a/src/backend/postmaster/autovacuum.c
+++ b/src/backend/postmaster/autovacuum.c
@@ -2598,7 +2598,8 @@ deleted:
 
        PushActiveSnapshot(GetTransactionSnapshot());
        perform_work_item(workitem);
-       PopActiveSnapshot();
+       if (ActiveSnapshotSet())    /* transaction could have aborted */
+           PopActiveSnapshot();
 
        /*
         * Check for config changes before acquiring lock for further jobs.