Add vacuum_delay_point call in compute_index_stats's per-sample-row loop.

Slow functions in index expressions might cause this loop to take long
enough to make it worth being cancellable.  Probably it would be enough
to call CHECK_FOR_INTERRUPTS here, but for consistency with other
per-sample-row loops in this file, let's use vacuum_delay_point.

Report and patch by Jeff Janes.  Back-patch to all supported branches.

diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c
index 954e5a68b6bd088e6db71aa2d14459a0b3c1f40b..2282f8b052a17bca5450333a8f4c0208e53c2916 100644 (file)
--- a/src/backend/commands/analyze.c
+++ b/src/backend/commands/analyze.c
@@ -743,6 +743,8 @@ compute_index_stats(Relation onerel, double totalrows,
        {
            HeapTuple   heapTuple = rows[rowno];
 
+           vacuum_delay_point();
+
            /*
             * Reset the per-tuple context each time, to reclaim any cruft
             * left behind by evaluating the predicate or index expressions.