Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iCamilo/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: 0xLopez/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 10 files changed
  • 4 contributors

Commits on Sep 21, 2020

  1. Update to recommended settings (Xcode 12)

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    61f0cd5 View commit details
    Browse the repository at this point in the history

  2. Replace #file with the new #filePath

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f00d440 View commit details
    Browse the repository at this point in the history

  3. Update CI config to use Xcode 12

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9bdb08b View commit details
    Browse the repository at this point in the history

  4. Update README

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    ac0f5c1 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #35 from essentialdevelopercom/xcode12 

    Update to Xcode 12
    @mapostolakis
    mapostolakis authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    a8ca4b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Guarantee load method requests data from URL

    Juan López committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    df5d2b7 View commit details
    Browse the repository at this point in the history

  2. Guarantee load delivers connectivity error on client error

    Juan López committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    01feffb View commit details
    Browse the repository at this point in the history

  3. Guarantee load delivers invalidData error on non 200 HTTP response

    Juan López committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    25a9039 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Delivers invalid data error on 200 HTTP response with invalid json

    Juan López committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    b8c57c6 View commit details
    Browse the repository at this point in the history

  2. Delivers success with no items on 200 HTTP response with empty json list

    Juan López committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    f859bf4 View commit details
    Browse the repository at this point in the history

  3. Guarantee delivering of success with items on 200 HTTP response with … 

    …json items
    Juan López committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    01d5500 View commit details
    Browse the repository at this point in the history

  4. Move decodable mapping logic to a new class FeedImagesMapper to dec… 

    …ouple the Feed Feature module from API implementation data
    Juan López committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    f05cf72 View commit details
    Browse the repository at this point in the history

  5. Move FeedImagesMapper to its own file

    Juan López committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    3be54d9 View commit details
    Browse the repository at this point in the history

  6. Guarantee we do not deliver a result through the completion closure a… 

    …fter the `RemoteFeedLoader` instance has been deallocated
    Juan López committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    6582d45 View commit details
    Browse the repository at this point in the history

  7. Remove coments

    Juan López committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    445513a View commit details
    Browse the repository at this point in the history

  8. Merge pull request #1 from 0xLopez/imageLoader 

    Feed load implementation
    @0xLopez
    0xLopez authored Oct 25, 2020
    Configuration menu
    Copy the full SHA
    d3e336d View commit details
    Browse the repository at this point in the history
Loading