Skip to content

Commit fd3699a

Browse files
authored
Merge pull request MongoEngine#2452 from bagerard/github_actions_improvements
improve github actions
2 parents 700fe80 + 4f6a244 commit fd3699a

File tree

1 file changed

+5
-15
lines changed

1 file changed

+5
-15
lines changed

.github/workflows/github-actions.yml

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ env:
2424

2525
jobs:
2626
linting:
27+
# Run pre-commit (https://pre-commit.com/)
28+
# which runs pre-configured linter & autoformatter
2729
runs-on: ubuntu-latest
2830
steps:
2931
- uses: actions/checkout@v2
@@ -94,21 +96,10 @@ jobs:
9496
cd docs
9597
make html-readthedocs
9698
97-
irc_notification:
98-
runs-on: ubuntu-latest
99-
needs: [linting, test]
100-
steps:
101-
- uses: rectalogic/notify-irc@v1
102-
if: success()
103-
with:
104-
channel: "irc.freenode.org#mongoengine"
105-
nickname: github-notifier
106-
message: |
107-
Build ${{ job.status }} - ${{ github.actor }} ${{ github.event_name }} ${{ github.event.ref }}
108-
10999
build-n-publish-dummy:
110100
runs-on: ubuntu-latest
111-
needs: [linting, test]
101+
needs: [linting, test, build_doc_dryrun]
102+
if: github.event_name != 'pull_request'
112103
steps:
113104
- uses: actions/checkout@master
114105
- name: Set up Python 3.7
@@ -123,15 +114,14 @@ jobs:
123114
# # Although working and recommended, test-pypi has a limit
124115
# # in the size of projects so it's better to avoid publishing
125116
# # until there is a way to garbage collect these dummy releases
126-
# if: github.event_name != 'pull_request'
127117
# uses: pypa/gh-action-pypi-publish@master
128118
# with:
129119
# password: ${{ secrets.test_pypi_token }}
130120
# repository_url: https://test.pypi.org/legacy/
131121

132122
build-n-publish:
133123
runs-on: ubuntu-latest
134-
needs: [linting, test]
124+
needs: [linting, test, build_doc_dryrun, build-n-publish-dummy]
135125
if: github.event_name == 'create' && startsWith(github.ref, 'refs/tags/v')
136126
steps:
137127
- uses: actions/checkout@master

0 commit comments

Comments
 (0)