Fix simplified page extension toolbar API

Author: yakky

cms/extensions/toolbar.py

@@ -65,7 +65,7 @@ def _setup_extension_toolbar(self):
         if get_cms_setting('PERMISSION'):
             has_global_current_page_change_permission = has_page_change_permission(self.request)
         else:
-            has_global_current_page_change_permission = False
+            has_global_current_page_change_permission = True
             # check if user has page edit permission
         can_change = (self.request.current_page and
                       self.request.current_page.has_change_permission(self.request))
@@ -147,7 +147,7 @@ def get_title_extension_admin(self, language=None):
                 urls.append((title_extension, admin_url))
         return urls
 
-    def _get_sub_menu(self, current_menu, key, label, position):
+    def _get_sub_menu(self, current_menu, key, label, position=None):
         """
         Utility function to get a submenu of the current menu
         """

docs/extending_cms/extending_page_title.rst

@@ -148,13 +148,14 @@ Similarly for title extensions::
             # if it's all ok
             if current_page_menu and self.toolbar.edit_mode:
                 # create a sub menu
+                position = 0
                 sub_menu = self._get_sub_menu(current_page_menu, 'submenu_label', 'Submenu', position)
                 # retrieves the instances of the current title extension (if any) and the toolbar item url
                 urls = self.get_title_extension_admin()
                 # cycle through the title list
                 for title_extension, url in urls:
                     # adds toolbar items
-                    sub_menu.add_modal_item('icon for title %s' % title,
+                    sub_menu.add_modal_item('icon for title %s' % self._page().get_title(),
                                             url=url, disabled=not self.toolbar.edit_mode)
 
 For details see the :ref:`reference <simplified_extension_toolbar>`