Skip to content

Commit cb2dba6

Browse files
authored
Remove useless privacy validation (prebid#1642)
1 parent 710001d commit cb2dba6

File tree

2 files changed

+0
-41
lines changed

2 files changed

+0
-41
lines changed

src/main/java/org/prebid/server/auction/requestfactory/AmpRequestFactory.java

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,6 @@ private Future<BidRequest> parseBidRequest(HttpRequestContext httpRequest, Aucti
183183
.ext(createExt(httpRequest, tagId, debug))
184184
.build();
185185

186-
validateOriginalBidRequest(bidRequest, consentString, auctionContext);
187-
188186
return Future.succeededFuture(bidRequest);
189187
}
190188

@@ -315,30 +313,6 @@ private static Map<String, String> ampDataFromQueryString(HttpRequestContext htt
315313
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue, (value1, value2) -> value1));
316314
}
317315

318-
private static void validateOriginalBidRequest(
319-
BidRequest bidRequest,
320-
String requestConsentString,
321-
AuctionContext auctionContext) {
322-
323-
final User user = bidRequest.getUser();
324-
final ExtUser extUser = user != null ? user.getExt() : null;
325-
final String gdprConsentString = extUser != null ? extUser.getConsent() : null;
326-
327-
final Regs regs = bidRequest.getRegs();
328-
final ExtRegs extRegs = regs != null ? regs.getExt() : null;
329-
final String usPrivacy = extRegs != null ? extRegs.getUsPrivacy() : null;
330-
331-
if (StringUtils.isAllBlank(gdprConsentString, usPrivacy)) {
332-
final String message = String.format(
333-
"Amp request parameter %s or %s have invalid format: %s",
334-
CONSENT_PARAM,
335-
GDPR_CONSENT_PARAM,
336-
requestConsentString);
337-
logger.debug(message);
338-
auctionContext.getPrebidErrors().add(message);
339-
}
340-
}
341-
342316
/**
343317
* Creates {@link BidRequest} and sets properties which were not set explicitly by the client, but can be
344318
* updated by values derived from headers and other request attributes.

src/test/java/org/prebid/server/auction/requestfactory/AmpRequestFactoryTest.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1309,21 +1309,6 @@ public void shouldReturnBidRequestWithoutUserWhenGdprConsentQueryParamIsInvalid(
13091309
assertThat(result.getUser()).isNull();
13101310
}
13111311

1312-
@Test
1313-
public void shouldAddErrorToAuctionContextWhenGdprConsentQueryParamIsInvalid() {
1314-
// given
1315-
routingContext.queryParams().add("gdpr_consent", "consent-value");
1316-
1317-
givenBidRequest();
1318-
1319-
// when
1320-
final AuctionContext result = target.fromRequest(routingContext, 0L).result();
1321-
1322-
// then
1323-
assertThat(result.getPrebidErrors())
1324-
.contains("Amp request parameter consent_string or gdpr_consent have invalid format: consent-value");
1325-
}
1326-
13271312
@Test
13281313
public void shouldReturnBidRequestWithExtPrebidDataBiddersUpdatedByFpdResolver() throws JsonProcessingException {
13291314
// given

0 commit comments

Comments
 (0)