Merge pull request openlayers#446 from candeira/fix_ticket_3554

Fix for trac ticket # 3554 single-arg Map constructor does not work if you pass a DOM element ref

Author: ahocevar

lib/OpenLayers/Map.js

@@ -545,7 +545,8 @@ OpenLayers.Map = OpenLayers.Class({
     initialize: function (div, options) {
 
         // If only one argument is provided, check if it is an object.
-        if(arguments.length === 1 && typeof div === "object") {
+        var isDOMElement = OpenLayers.Util.isElement(div);
+        if(arguments.length === 1 && typeof div === "object" && !isDOMElement) {
             options = div;
             div = options && options.div;
         }

tests/Map.html

@@ -130,6 +130,22 @@
         map.destroy();
     }
 
+    function test_Map_constructor_renderTo_DOM_element_ref(t) {
+        t.plan( 1 );
+
+        var map_div = document.getElementById('map');
+        map = new OpenLayers.Map(map_div); 
+        var baseLayer = new OpenLayers.Layer.WMS("Test Layer", 
+            "http://octo.metacarta.com/cgi-bin/mapserv?",
+            {map: "/mapdata/vmap_wms.map", layers: "basic"});
+        map.addLayer(baseLayer);
+        
+        var mapDiv = document.getElementById("map");
+        t.ok(map.div == mapDiv, "Map is rendered to the 'map' div.")
+        
+        map.destroy();
+    }
+
     function test_Map_setOptions(t) {
         t.plan(2);
         map = new OpenLayers.Map('map', {maxExtent: new OpenLayers.Bounds(100, 200, 300, 400)});