Fix no_ack meaning

no_ack = true is equivalent to autoack

[#154472211]

Author: dcorbacho

src/rabbit_amqqueue.erl

@@ -1041,9 +1041,9 @@ basic_get(#amqqueue{name = QName, pid = {Name, _} = Id, type = quorum}, ChPid, N
         {ra_event, _, machine, {msg, MsgId, Msg}} ->
             case NoAck of
                 true ->
-                    ok;
+                    {ok, _, _} = ra:send_and_await_consensus(Id, {settle, MsgId, self()});
                 false ->
-                    {ok, _, _} = ra:send_and_await_consensus(Id, {settle, MsgId, self()})
+                    ok
             end,
             {ok, quorum_messages(Name), {QName, Id, MsgId, false, Msg}}
     end.

test/quorum_queue_SUITE.erl

@@ -279,7 +279,7 @@ consume_from_queue(Config) ->
 
     publish(Ch, QQ),
     wait_for_messages(Config, 0, QQ, <<"1">>, <<"1">>, <<"0">>),
-    consume(Ch, QQ, true),
+    consume(Ch, QQ, false),
     wait_for_messages(Config, 0, QQ, <<"1">>, <<"0">>, <<"1">>),
     rabbit_ct_client_helpers:close_channel(Ch),
     wait_for_messages(Config, 0, QQ, <<"1">>, <<"1">>, <<"0">>).
@@ -296,7 +296,7 @@ consume_and_autoack_from_queue(Config) ->
 
     publish(Ch, QQ),
     wait_for_messages(Config, 0, QQ, <<"1">>, <<"1">>, <<"0">>),
-    consume(Ch, QQ, false),
+    consume(Ch, QQ, true),
     wait_for_messages(Config, 0, QQ, <<"0">>, <<"0">>, <<"0">>),
     rabbit_ct_client_helpers:close_channel(Ch),
     wait_for_messages(Config, 0, QQ, <<"0">>, <<"0">>, <<"0">>).
@@ -311,7 +311,7 @@ consume_from_empty_queue(Config) ->
     ?assertEqual({'queue.declare_ok', QQ, 0, 0},
                  declare(Ch, QQ, [{<<"x-queue-type">>, longstr, <<"quorum">>}])),
 
-    consume_empty(Ch, QQ, true).
+    consume_empty(Ch, QQ, false).
 
 %%----------------------------------------------------------------------------