fixing from_documents method of the MongoDB Atlas vector store (langchain-ai#5794)

P-E-B · web-flow · commit daf3e99b9623 · 2023-06-06T14:22:23.000-07:00
FIxed a bug in from_documents method --> Collection objects do not implement truth value testing or bool(). @dev2049
diff --git a/langchain/vectorstores/mongodb_atlas.py b/langchain/vectorstores/mongodb_atlas.py
@@ -262,7 +262,7 @@ def from_texts(
                     collection=collection
                 )
         """
-        if not collection:
+        if collection is None:
             raise ValueError("Must provide 'collection' named parameter.")
         vecstore = cls(collection, embedding, **kwargs)
         vecstore.add_texts(texts, metadatas=metadatas)

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ def from_texts(`
`262`	`262`	`collection=collection`
`263`	`263`	`)`
`264`	`264`	`"""`
`265`		`- if not collection:`
	`265`	`+ if collection is None:`
`266`	`266`	`raise ValueError("Must provide 'collection' named parameter.")`
`267`	`267`	`vecstore = cls(collection, embedding, **kwargs)`
`268`	`268`	`vecstore.add_texts(texts, metadatas=metadatas)`