more controls, minor fixes on BE.

Author: mertakdut

BankApplicationBackend/src/main/java/com/demo/bankapp/configuration/DatabaseMocker.java

@@ -3,6 +3,8 @@
 import org.springframework.boot.CommandLineRunner;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
+import org.springframework.core.Ordered;
+import org.springframework.core.annotation.Order;
 
 import com.demo.bankapp.controller.UserController;
 import com.demo.bankapp.repository.UserRepository;
@@ -12,17 +14,18 @@
 class DatabaseMocker {
 
 	@Bean
+	@Order(Ordered.HIGHEST_PRECEDENCE)
 	CommandLineRunner initDatabase(UserRepository repository, UserController userController) {
 		return args -> {
 			CreateNewUserRequest cnuRequest = new CreateNewUserRequest();
 			cnuRequest.setUsername("Mert");
 			cnuRequest.setPassword("mert123");
-			cnuRequest.setTcno("2141232211");
+			cnuRequest.setTcno("21412322112");
 
 			CreateNewUserRequest cnuRequest2 = new CreateNewUserRequest();
 			cnuRequest2.setUsername("Mert2");
 			cnuRequest2.setPassword("mert1234");
-			cnuRequest2.setTcno("2141232212");
+			cnuRequest2.setTcno("23141232212");
 
 			userController.createNewUser(cnuRequest);
 			userController.createNewUser(cnuRequest2);

BankApplicationBackend/src/main/java/com/demo/bankapp/controller/TransactionController.java

@@ -1,14 +1,12 @@
 package com.demo.bankapp.controller;
 
-import java.math.BigDecimal;
 import java.util.List;
 import java.util.stream.Collectors;
 
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.hateoas.Resource;
 import org.springframework.http.MediaType;
 import org.springframework.web.bind.annotation.CrossOrigin;
-import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -19,6 +17,7 @@
 import com.demo.bankapp.exception.DailyOperationLimitReachedException;
 import com.demo.bankapp.model.Transaction;
 import com.demo.bankapp.model.User;
+import com.demo.bankapp.request.FindAllByUserRequest;
 import com.demo.bankapp.request.MakeTransactionRequest;
 import com.demo.bankapp.service.concretions.TransactionService;
 import com.demo.bankapp.service.concretions.UserService;
@@ -44,11 +43,19 @@ public class TransactionController {
 	@PostMapping("/make")
 	public Resource<Transaction> makeTransaction(@RequestBody MakeTransactionRequest request) {
 
-		if (request == null || request.getUsername() == null || request.getUsername().equals("") || request.getCurrency() == null || request.getCurrency().equals("")) {
+		if (request == null) {
 			throw new BadRequestException();
 		}
 
-		if (request.getAmount().signum() == 0 || request.getAmount().signum() == -1) {
+		if (request.getUsername() == null || request.getUsername().equals("")) {
+			throw new BadRequestException("Invalid username.");
+		}
+
+		if (request.getCurrency() == null || request.getCurrency().equals("")) {
+			throw new BadRequestException("Invalid currency.");
+		}
+
+		if (request.getAmount() != null && request.getAmount().signum() == 0 || request.getAmount().signum() == -1) {
 			throw new BadRequestException("Invalid amount.");
 		}
 
@@ -69,9 +76,19 @@ public Resource<Transaction> makeTransaction(@RequestBody MakeTransactionRequest
 		return assembler.toResource(transaction);
 	}
 
-	@GetMapping("/findAll")
-	public List<Resource<Transaction>> findAll() {
-		return transactionService.findAll().stream().map(assembler::toResource).collect(Collectors.toList());
+	@PostMapping("/findAllByUsername")
+	public List<Resource<Transaction>> findAllByUsername(@RequestBody FindAllByUserRequest request) {
+
+		if (request == null) {
+			throw new BadRequestException();
+		}
+
+		if (request.getUsername() == null || request.getUsername().equals("")) {
+			throw new BadRequestException("Invalid username.");
+		}
+
+		User user = userService.findByUserName(request.getUsername());
+		return transactionService.findAllByUserId(user.getId()).stream().map(assembler::toResource).collect(Collectors.toList());
 	}
 
 }

BankApplicationBackend/src/main/java/com/demo/bankapp/controller/TransferController.java

@@ -1,9 +1,5 @@
 package com.demo.bankapp.controller;
 
-import java.math.BigDecimal;
-
-import javax.validation.constraints.NotNull;
-
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.hateoas.Resource;
 import org.springframework.http.MediaType;
@@ -15,7 +11,6 @@
 
 import com.demo.bankapp.assembler.TransferResourceAssembler;
 import com.demo.bankapp.exception.BadRequestException;
-import com.demo.bankapp.model.Transaction;
 import com.demo.bankapp.model.Transfer;
 import com.demo.bankapp.model.User;
 import com.demo.bankapp.request.MakeTransferRequest;

BankApplicationBackend/src/main/java/com/demo/bankapp/repository/TransactionRepository.java

@@ -1,5 +1,7 @@
 package com.demo.bankapp.repository;
 
+import java.util.List;
+
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Query;
 import org.springframework.data.repository.query.Param;
@@ -12,5 +14,7 @@ public interface TransactionRepository extends JpaRepository<Transaction, Long>
 
 	@Query(value = "SELECT COUNT(*) FROM Transaction WHERE transactionTime >= DATEADD(day, -1, GETDATE())")
 	int getOperationCountFromLast24Hours(@Param("userId") Long userId);
+	
+	List<Transaction> findAllByUserId(Long userId);
 
 }

BankApplicationBackend/src/main/java/com/demo/bankapp/service/abstractions/ITransactionService.java

@@ -11,6 +11,6 @@ public interface ITransactionService {
 
 	int getOperationCountFromLast24Hours(Long userId);
 
-	List<Transaction> findAll();
+	List<Transaction> findAllByUserId(Long userId);
 
 }

BankApplicationBackend/src/main/java/com/demo/bankapp/service/concretions/TransactionService.java

@@ -28,8 +28,8 @@ public int getOperationCountFromLast24Hours(Long userId) {
 	}
 
 	@Override
-	public List<Transaction> findAll() {
-		return repository.findAll();
+	public List<Transaction> findAllByUserId(Long userId) {
+		return repository.findAllByUserId(userId);
 	}
 
 }

BankApplicationBackend/src/main/java/com/demo/bankapp/service/concretions/UserService.java

@@ -59,7 +59,7 @@ public User findByTcno(String tcno) {
 		User user = repository.findByTcno(tcno);
 
 		if (user == null)
-			throw new UserNotFoundException(tcno);
+			throw new UserNotFoundException("with TC No: " + tcno);
 		else
 			return user;
 	}