Skip to content

Commit bb5d319

Browse files
committed
Merge branch 'poll-bug'
2 parents 4ad6ac0 + 3fde1f6 commit bb5d319

File tree

1 file changed

+22
-15
lines changed

1 file changed

+22
-15
lines changed

public/scripts/friend-poll.js

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ $(document).ready(function() {
77

88
$(".choice").on("dragstart", function (event) {
99
$dragged = $(this);
10+
$parentDiv = $(this).parent();
1011
$dragged.addClass("on-drag");
1112
});
1213

1314
$(".choice").on("dragend", function (event) {
1415
$(this).removeClass("on-drag");
1516
$dragged = null;
17+
$parentDiv = null;
1618
});
1719

1820
$(".choice-container").on("dragover", function (event) {
@@ -21,25 +23,30 @@ $(document).ready(function() {
2123

2224
// making choices
2325
$(".choice-container.empty").on("drop", function (event) {
24-
choicesMade += 1;
25-
event.preventDefault();
26-
$(this).append($dragged);
27-
$dragged.attr("ranking", choicesMade);
26+
if ($parentDiv.hasClass("full")) {
27+
choicesMade += 1;
28+
}
29+
event.preventDefault();
30+
$(this).append($dragged);
31+
$dragged.attr("ranking", choicesMade);
32+
2833
});
2934

3035
// undoing choices
3136
$(".choice-container.full").on("drop", function (event) {
32-
choicesMade -= 1;
33-
event.preventDefault();
34-
$(this).append($dragged);
35-
let undoRank = Number($dragged.attr("ranking"));
36-
$dragged.attr("ranking", 0);
37-
$(this).siblings(".choice-container.empty").children(".choice").each(function () {
38-
let oldRank = Number($(this).attr("ranking"));
39-
if (oldRank > undoRank) {
40-
$(this).attr("ranking", oldRank-1);
41-
}
42-
});
37+
if ($parentDiv.hasClass("empty")) {
38+
choicesMade -= 1;
39+
}
40+
event.preventDefault();
41+
$(this).append($dragged);
42+
let undoRank = Number($dragged.attr("ranking"));
43+
$dragged.attr("ranking", 0);
44+
$(this).siblings(".choice-container.empty").children(".choice").each(function () {
45+
let oldRank = Number($(this).attr("ranking"));
46+
if (oldRank > undoRank) {
47+
$(this).attr("ranking", oldRank-1);
48+
}
49+
});
4350
});
4451

4552
$(".submit-ranks-btn").on("click", function (event) {

0 commit comments

Comments
 (0)