Skip to content

Commit 89f23df

Browse files
authored
Merge pull request spinen#44 from spinen/develop
Merge 0.3.4 into master
2 parents bbd7cfb + 1fe79e6 commit 89f23df

File tree

6 files changed

+58
-6
lines changed

6 files changed

+58
-6
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.3.0
1+
0.3.4

readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ NOTE: This is based off a video titled ["Testing Email With Custom Assertions"](
55
[![Latest Stable Version](https://poser.pugx.org/spinen/laravel-mail-assertions/v/stable)](https://packagist.org/packages/spinen/laravel-mail-assertions)
66
[![Total Downloads](https://poser.pugx.org/spinen/laravel-mail-assertions/downloads)](https://packagist.org/packages/spinen/laravel-mail-assertions)
77
[![Latest Unstable Version](https://poser.pugx.org/spinen/laravel-mail-assertions/v/unstable)](https://packagist.org/packages/spinen/laravel-mail-assertions#dev-master)
8-
[![Dependency Status](https://gemnasium.com/spinen/laravel-mail-assertions.png)](https://gemnasium.com/spinen/laravel-mail-assertions)
8+
[![Dependency Status](https://gemnasium.com/spinen/laravel-mail-assertions.svg)](https://gemnasium.com/spinen/laravel-mail-assertions)
99
[![License](https://poser.pugx.org/spinen/laravel-mail-assertions/license)](https://packagist.org/packages/spinen/laravel-mail-assertions)
1010

1111
PHPUnit mail assertions for testing email in Laravel.

src/MailTracking.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function setUpMailTracking()
6060
return;
6161
}
6262

63-
// For PhpUnit 6 and Laravel > 5.1, register the plugin after the app is booted
63+
// For PhpUnit 6 and Laravel > 5.2, register the plugin after the app is booted
6464
$this->afterApplicationCreated(function () use ($register_plugin) {
6565
$register_plugin();
6666
});

tests/MailRecorderTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ public function it_cannot_be_constructed_without_a_PHPUnit_Framework_TestCase()
5151
*/
5252
public function it_cannot_be_constructed_with_class_other_than_a_PHPUnit_Framework_TestCase()
5353
{
54-
// TODO: Skipping this until resolving PhpUnit 6 vs. 7 support
55-
$this->markTestSkipped();
56-
5754
if (class_exists(TypeError::class)) {
5855
try {
5956
new MailRecorder(new StdClass());

tests/MailTrackingTest.php

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
use Mockery;
77
use ReflectionClass;
88
use Spinen\MailAssertions\Stubs\MailTrackingStub as MailTracking;
9+
use Spinen\MailAssertions\Stubs\OldMailTrackingStub as OldMailTracking;
910
use Swift_Mailer;
1011
use Swift_Message;
1112

@@ -115,6 +116,33 @@ public function it_registers_MailRecorder_withMail_in_the_setup_with_before_anno
115116
$this->mail_tracking->setUpMailTracking();
116117
}
117118

119+
/**
120+
* @test
121+
* @group unit
122+
*/
123+
public function it_registers_MailRecorder_without_afterApplicationCreated_method_present()
124+
{
125+
// Use a version of the MailTrackingStub without the afterApplicationCreated method
126+
$this->mail_tracking = new OldMailTracking();
127+
128+
$swift_mock = Mockery::mock(Swift_Mailer::class);
129+
130+
$swift_mock->shouldReceive('registerPlugin')
131+
->once()
132+
->with(Mockery::on(function($closure) {
133+
return is_a($closure, MailRecorder::class);
134+
}))
135+
->andReturnNull();
136+
137+
Mail::shouldReceive('getSwiftMailer')
138+
->once()
139+
->withNoArgs()
140+
->andReturn($swift_mock);
141+
142+
// TODO: Get this method name by parsing annotations
143+
$this->mail_tracking->setUpMailTracking();
144+
}
145+
118146
/**
119147
* @test
120148
* @group unit

tests/Stubs/OldMailTrackingStub.php

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<?php
2+
3+
namespace Spinen\MailAssertions\Stubs;
4+
5+
use Spinen\MailAssertions\MailTracking;
6+
use Spinen\MailAssertions\TestCase;
7+
8+
/**
9+
* Class MailTrackingStub
10+
*
11+
* @package Spinen\MailAssertions\Stubs
12+
*/
13+
class OldMailTrackingStub extends TestCase
14+
{
15+
use MailTracking;
16+
17+
/**
18+
* Public method in the stub to expose the protected email collection
19+
*
20+
* This is only needed in the tests to allow access to the raw collection of messages.
21+
*
22+
* @return array
23+
*/
24+
public function exposeMessage() {
25+
return $this->emails;
26+
}
27+
}

0 commit comments

Comments
 (0)