target .net 8 and seal more classes

Author: lbargaoanu

src/AutoMapper/ApiCompatBaseline.txt

@@ -39,8 +39,25 @@ CannotChangeAttribute : Attribute 'System.AttributeUsageAttribute' on 'AutoMappe
 CannotChangeAttribute : Attribute 'System.AttributeUsageAttribute' on 'AutoMapper.Configuration.Annotations.UseExistingValueAttribute' changed from '[AttributeUsageAttribute(384)]' in the contract to '[AttributeUsageAttribute(AttributeTargets.Field | AttributeTargets.Property)]' in the implementation.
 CannotChangeAttribute : Attribute 'System.AttributeUsageAttribute' on 'AutoMapper.Configuration.Annotations.ValueConverterAttribute' changed from '[AttributeUsageAttribute(384)]' in the contract to '[AttributeUsageAttribute(AttributeTargets.Field | AttributeTargets.Property)]' in the implementation.
 CannotChangeAttribute : Attribute 'System.AttributeUsageAttribute' on 'AutoMapper.Configuration.Annotations.ValueResolverAttribute' changed from '[AttributeUsageAttribute(384)]' in the contract to '[AttributeUsageAttribute(AttributeTargets.Field | AttributeTargets.Property)]' in the implementation.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.AssignableMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.CollectionMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.ConstructorMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.ConversionOperatorMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.ConvertMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.EnumToEnumMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.FromDynamicMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.FromStringDictionaryMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.KeyValueMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
 CannotSealType : Type 'AutoMapper.Internal.Mappers.MultidimensionalArrayFiller' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
 TypeCannotChangeClassification : Type 'AutoMapper.Internal.Mappers.MultidimensionalArrayFiller' is a 'struct' in the implementation but is a 'class' in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.NullableDestinationMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.NullableSourceMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.ParseStringMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.StringToEnumMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.ToDynamicMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.ToStringDictionaryMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.ToStringMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
+CannotSealType : Type 'AutoMapper.Internal.Mappers.UnderlyingTypeEnumMapper' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
 CannotRemoveAttribute : Attribute 'System.Runtime.CompilerServices.NullableContextAttribute' exists on 'AutoMapper.QueryableExtensions.Extensions.ProjectTo(System.Linq.IQueryable, System.Type, AutoMapper.IConfigurationProvider)' in the contract but not the implementation.
 CannotRemoveAttribute : Attribute 'System.Runtime.CompilerServices.NullableContextAttribute' exists on 'AutoMapper.QueryableExtensions.Extensions.ProjectTo(System.Linq.IQueryable, System.Type, AutoMapper.IConfigurationProvider, System.Collections.Generic.IDictionary<System.String, System.Object>, System.String[])' in the contract but not the implementation.
 CannotRemoveAttribute : Attribute 'System.Runtime.CompilerServices.NullableAttribute' exists on parameter 'parameters' on member 'AutoMapper.QueryableExtensions.Extensions.ProjectTo(System.Linq.IQueryable, System.Type, AutoMapper.IConfigurationProvider, System.Collections.Generic.IDictionary<System.String, System.Object>, System.String[])' in the contract but not the implementation.
@@ -52,4 +69,4 @@ CannotRemoveAttribute : Attribute 'System.Runtime.CompilerServices.NullableAttri
 CannotRemoveAttribute : Attribute 'System.Runtime.CompilerServices.NullableContextAttribute' exists on 'AutoMapper.QueryableExtensions.Extensions.ProjectTo<TDestination>(System.Linq.IQueryable, AutoMapper.IConfigurationProvider, System.Object, System.Linq.Expressions.Expression<System.Func<TDestination, System.Object>>[])' in the contract but not the implementation.
 CannotRemoveAttribute : Attribute 'System.Runtime.CompilerServices.NullableAttribute' exists on parameter 'parameters' on member 'AutoMapper.QueryableExtensions.Extensions.ProjectTo<TDestination>(System.Linq.IQueryable, AutoMapper.IConfigurationProvider, System.Object, System.Linq.Expressions.Expression<System.Func<TDestination, System.Object>>[])' in the contract but not the implementation.
 CannotRemoveAttribute : Attribute 'System.Runtime.CompilerServices.NullableAttribute' exists on generic param 'TDestination' on member 'AutoMapper.QueryableExtensions.Extensions.ProjectTo<TDestination>(System.Linq.IQueryable, AutoMapper.IConfigurationProvider, System.Object, System.Linq.Expressions.Expression<System.Func<TDestination, System.Object>>[])' in the contract but not the implementation.
-Total Issues: 53
+Total Issues: 70

src/AutoMapper/AutoMapper.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <Summary>A convention-based object-object mapper.</Summary>
     <Description>A convention-based object-object mapper.</Description>
-    <TargetFrameworks>net6.0</TargetFrameworks>
+    <TargetFrameworks>net8.0</TargetFrameworks>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <AssemblyName>AutoMapper</AssemblyName>
     <AssemblyOriginatorKeyFile>..\..\AutoMapper.snk</AssemblyOriginatorKeyFile>
@@ -38,7 +38,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Extensions.Options" Version="6.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Options" Version="8.0.0" />
     <PackageReference Include="MinVer" Version="4.3.0" PrivateAssets="All" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
     <PackageReference Include="Microsoft.DotNet.ApiCompat" Version="7.0.0-beta.22074.1" PrivateAssets="All" />  

src/AutoMapper/Mappers/AssignableMapper.cs

@@ -1,6 +1,6 @@
 namespace AutoMapper.Internal.Mappers;
 
-public class AssignableMapper : IObjectMapper
+public sealed class AssignableMapper : IObjectMapper
 {
     public bool IsMatch(TypePair context) => context.DestinationType.IsAssignableFrom(context.SourceType);
     public Expression MapExpression(IGlobalConfiguration configuration, ProfileMap profileMap,

src/AutoMapper/Mappers/CollectionMapper.cs

@@ -3,7 +3,7 @@
 using System.Collections.Specialized;
 namespace AutoMapper.Internal.Mappers;
 using static ReflectionHelper;
-public class CollectionMapper : IObjectMapper
+public sealed class CollectionMapper : IObjectMapper
 {
     static readonly MethodInfo IListAdd = typeof(IList).GetMethod(nameof(IList.Add));
     public TypePair? GetAssociatedTypes(TypePair context) => new(GetElementType(context.SourceType), GetElementType(context.DestinationType));

src/AutoMapper/Mappers/ConstructorMapper.cs

@@ -1,5 +1,5 @@
 namespace AutoMapper.Internal.Mappers;
-public class ConstructorMapper : IObjectMapper
+public sealed class ConstructorMapper : IObjectMapper
 {
     public bool IsMatch(TypePair context) => GetConstructor(context.SourceType, context.DestinationType) != null;
     private static ConstructorInfo GetConstructor(Type sourceType, Type destinationType) => 

src/AutoMapper/Mappers/ConversionOperatorMapper.cs

@@ -1,5 +1,5 @@
 namespace AutoMapper.Internal.Mappers;
-public class ConversionOperatorMapper : IObjectMapper
+public sealed class ConversionOperatorMapper : IObjectMapper
 {
     private readonly string _operatorName;
     public ConversionOperatorMapper(string operatorName) => _operatorName = operatorName;

src/AutoMapper/Mappers/ConvertMapper.cs

@@ -1,5 +1,5 @@
 namespace AutoMapper.Internal.Mappers;
-public class ConvertMapper : IObjectMapper
+public sealed class ConvertMapper : IObjectMapper
 {
     public static bool IsPrimitive(Type type) => type.IsPrimitive || type == typeof(string) || type == typeof(decimal);
     public bool IsMatch(TypePair types) => (types.SourceType == typeof(string) && types.DestinationType == typeof(DateTime)) || 

src/AutoMapper/Mappers/EnumToEnumMapper.cs

@@ -1,5 +1,5 @@
 namespace AutoMapper.Internal.Mappers;
-public class EnumToEnumMapper : IObjectMapper
+public sealed class EnumToEnumMapper : IObjectMapper
 {
     private static readonly MethodInfo TryParseMethod = typeof(Enum).StaticGenericMethod("TryParse", parametersCount: 3);
     public bool IsMatch(TypePair context) => context.IsEnumToEnum();

src/AutoMapper/Mappers/FromDynamicMapper.cs

@@ -2,7 +2,7 @@
 using Microsoft.CSharp.RuntimeBinder;
 using Binder = Microsoft.CSharp.RuntimeBinder.Binder;
 namespace AutoMapper.Internal.Mappers;
-public class FromDynamicMapper : IObjectMapper
+public sealed class FromDynamicMapper : IObjectMapper
 {
     private static readonly MethodInfo MapMethodInfo = typeof(FromDynamicMapper).GetStaticMethod(nameof(Map));
     private static object Map(object source, object destination, Type destinationType, ResolutionContext context, ProfileMap profileMap)

src/AutoMapper/Mappers/FromStringDictionaryMapper.cs

@@ -1,6 +1,6 @@
 using StringDictionary = System.Collections.Generic.IDictionary<string, object>;
 namespace AutoMapper.Internal.Mappers;
-public class FromStringDictionaryMapper : IObjectMapper
+public sealed class FromStringDictionaryMapper : IObjectMapper
 {
     private static readonly MethodInfo MapDynamicMethod = typeof(FromStringDictionaryMapper).GetStaticMethod(nameof(MapDynamic));
     public bool IsMatch(TypePair context) => typeof(StringDictionary).IsAssignableFrom(context.SourceType);

src/AutoMapper/Mappers/KeyValueMapper.cs

@@ -1,5 +1,5 @@
 namespace AutoMapper.Internal.Mappers;
-public class KeyValueMapper : IObjectMapper
+public sealed class KeyValueMapper : IObjectMapper
 {
     public bool IsMatch(TypePair context) => IsKeyValue(context.SourceType) && IsKeyValue(context.DestinationType);
     public static bool IsKeyValue(Type type) => type.IsGenericType(typeof(KeyValuePair<,>));

src/AutoMapper/Mappers/NullableDestinationMapper.cs

@@ -1,6 +1,6 @@
 namespace AutoMapper.Internal.Mappers;
 
-public class NullableDestinationMapper : IObjectMapper
+public sealed class NullableDestinationMapper : IObjectMapper
 {
     public bool IsMatch(TypePair context) => context.DestinationType.IsNullableType();
     public Expression MapExpression(IGlobalConfiguration configuration, ProfileMap profileMap, MemberMap memberMap, Expression sourceExpression, Expression destExpression) =>

src/AutoMapper/Mappers/NullableSourceMapper.cs

@@ -1,6 +1,6 @@
 namespace AutoMapper.Internal.Mappers;
 
-public class NullableSourceMapper : IObjectMapper
+public sealed class NullableSourceMapper : IObjectMapper
 {
     public bool IsMatch(TypePair context) => context.SourceType.IsNullableType();
     public Expression MapExpression(IGlobalConfiguration configuration, ProfileMap profileMap, MemberMap memberMap, Expression sourceExpression, Expression destExpression) =>

src/AutoMapper/Mappers/ParseStringMapper.cs

@@ -1,6 +1,6 @@
 namespace AutoMapper.Internal.Mappers;
 
-public class ParseStringMapper : IObjectMapper
+public sealed class ParseStringMapper : IObjectMapper
 {
     public bool IsMatch(TypePair context) => context.SourceType == typeof(string) && HasParse(context.DestinationType);
     static bool HasParse(Type type) => type == typeof(Guid) || type == typeof(TimeSpan) || type == typeof(DateTimeOffset);

src/AutoMapper/Mappers/StringToEnumMapper.cs

@@ -1,6 +1,6 @@
 using System.Runtime.Serialization;
 namespace AutoMapper.Internal.Mappers;
-public class StringToEnumMapper : IObjectMapper
+public sealed class StringToEnumMapper : IObjectMapper
 {
     private static readonly MethodInfo EqualsMethod = typeof(StringToEnumMapper).GetMethod(nameof(StringCompareOrdinalIgnoreCase));
     private static readonly MethodInfo ParseMethod = typeof(Enum).StaticGenericMethod("Parse", parametersCount: 2);

src/AutoMapper/Mappers/ToDynamicMapper.cs

@@ -2,7 +2,7 @@
 using Microsoft.CSharp.RuntimeBinder;
 using Binder = Microsoft.CSharp.RuntimeBinder.Binder;
 namespace AutoMapper.Internal.Mappers;
-public class ToDynamicMapper : IObjectMapper
+public sealed class ToDynamicMapper : IObjectMapper
 {
     private static readonly MethodInfo MapMethodInfo = typeof(ToDynamicMapper).GetStaticMethod(nameof(Map));
     private static object Map(object source, object destination, Type destinationType, ResolutionContext context, ProfileMap profileMap)

src/AutoMapper/Mappers/ToStringDictionaryMapper.cs

@@ -1,5 +1,5 @@
 namespace AutoMapper.Internal.Mappers;
-public class ToStringDictionaryMapper : IObjectMapper
+public sealed class ToStringDictionaryMapper : IObjectMapper
 {
     private static readonly MethodInfo MembersDictionaryMethodInfo = typeof(ToStringDictionaryMapper).GetStaticMethod(nameof(MembersDictionary));
     public bool IsMatch(TypePair context) => typeof(IDictionary<string, object>).IsAssignableFrom(context.DestinationType);

src/AutoMapper/Mappers/ToStringMapper.cs

@@ -1,5 +1,5 @@
 namespace AutoMapper.Internal.Mappers;
-public class ToStringMapper : IObjectMapper
+public sealed class ToStringMapper : IObjectMapper
 {
     public bool IsMatch(TypePair context) => context.DestinationType == typeof(string);
     public Expression MapExpression(IGlobalConfiguration configuration, ProfileMap profileMap, MemberMap memberMap, Expression sourceExpression, Expression destExpression)

src/AutoMapper/Mappers/UnderlyingEnumTypeMapper.cs

@@ -1,6 +1,6 @@
 namespace AutoMapper.Internal.Mappers;
 
-public class UnderlyingTypeEnumMapper : IObjectMapper
+public sealed class UnderlyingTypeEnumMapper : IObjectMapper
 {
     public bool IsMatch(TypePair context) => context.IsEnumToUnderlyingType() || context.IsUnderlyingTypeToEnum();
     public Expression MapExpression(IGlobalConfiguration configuration, ProfileMap profileMap,

src/AutoMapper/QueryableExtensions/ProjectionMappers/AssignableProjectionMapper.cs

@@ -1,6 +1,6 @@
 namespace AutoMapper.QueryableExtensions.Impl;
 [EditorBrowsable(EditorBrowsableState.Never)]
-public class AssignableProjectionMapper : IProjectionMapper
+public sealed class AssignableProjectionMapper : IProjectionMapper
 {
     public bool IsMatch(TypePair context) => context.DestinationType.IsAssignableFrom(context.SourceType);
     public Expression Project(IGlobalConfiguration configuration, in ProjectionRequest request, Expression resolvedSource, LetPropertyMaps letPropertyMaps)

src/AutoMapper/QueryableExtensions/ProjectionMappers/EnumProjectionMapper.cs

@@ -1,6 +1,6 @@
 namespace AutoMapper.QueryableExtensions.Impl;
 [EditorBrowsable(EditorBrowsableState.Never)]
-public class EnumProjectionMapper : IProjectionMapper
+public sealed class EnumProjectionMapper : IProjectionMapper
 {
     public Expression Project(IGlobalConfiguration configuration, in ProjectionRequest request, Expression resolvedSource, LetPropertyMaps letPropertyMaps)
         => Convert(resolvedSource, request.DestinationType);

src/AutoMapper/QueryableExtensions/ProjectionMappers/EnumerableProjectionMapper.cs

@@ -1,7 +1,7 @@
 namespace AutoMapper.QueryableExtensions.Impl;
 using static ReflectionHelper;
 [EditorBrowsable(EditorBrowsableState.Never)]
-public class EnumerableProjectionMapper : IProjectionMapper
+public sealed class EnumerableProjectionMapper : IProjectionMapper
 {
     private static readonly MethodInfo SelectMethod = typeof(Enumerable).StaticGenericMethod("Select", parametersCount: 2);
     private static readonly MethodInfo ToArrayMethod = typeof(Enumerable).GetStaticMethod("ToArray");

src/AutoMapper/QueryableExtensions/ProjectionMappers/NullableSourceProjectionMapper.cs

@@ -1,5 +1,5 @@
 namespace AutoMapper.QueryableExtensions.Impl;
-internal class NullableSourceProjectionMapper : IProjectionMapper
+public sealed class NullableSourceProjectionMapper : IProjectionMapper
 {
     public Expression Project(IGlobalConfiguration configuration, in ProjectionRequest request, Expression resolvedSource, LetPropertyMaps letPropertyMaps) =>
         Coalesce(resolvedSource, New(request.DestinationType));

src/AutoMapper/QueryableExtensions/ProjectionMappers/StringProjectionMapper.cs

@@ -1,7 +1,7 @@
 namespace AutoMapper.QueryableExtensions.Impl;
 
 [EditorBrowsable(EditorBrowsableState.Never)]
-public class StringProjectionMapper : IProjectionMapper
+public sealed class StringProjectionMapper : IProjectionMapper
 {
     public bool IsMatch(TypePair context) => context.DestinationType == typeof(string);
     public Expression Project(IGlobalConfiguration configuration, in ProjectionRequest request, Expression resolvedSource, LetPropertyMaps letPropertyMaps)