Skip to content

Commit 999cfff

Browse files
authored
Support Multi-line Upcoming Breaking Change announcement (#515)
* Support Multi-line Upcoming Breaking Change announcement * Prepare to release * Fix title underline * Use clear name * Upgrade to 0.2.0 !!
1 parent 647a5cb commit 999cfff

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
33
Release History
44
===============
5+
0.2.0
6+
+++++
7+
* `azdev generated-breaking-change-report`: Support multi-line upcoming breaking change announcement
8+
59
0.1.99
610
++++++
711
* `azdev verify`: Fix executable inconsistence in `subprocess`

azdev/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
# license information.
55
# -----------------------------------------------------------------------------
66

7-
__VERSION__ = '0.1.99'
7+
__VERSION__ = '0.2.0'

azdev/operations/breaking_change/__init__.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ def calc_ref(self, loader):
3636
else:
3737
self.group_ref = self.command.split()[:-1]
3838

39+
@property
40+
def prepended_detail(self):
41+
prepended_lines = [f'- {line}' if line else '' for line in self.detail.split('\n')]
42+
return '\n'.join(prepended_lines)
43+
3944

4045
def _load_commands():
4146
start = time.time()
@@ -300,9 +305,9 @@ def _group_breaking_change_items(iterator, group_by_version=False):
300305
version = item.target_version if item.target_version else 'Unspecific'
301306
upcoming_breaking_changes[item.module][item.command]['group_ref'] = item.group_ref
302307
if group_by_version:
303-
upcoming_breaking_changes[item.module][item.command]['items'][version].append(item.detail)
308+
upcoming_breaking_changes[item.module][item.command]['items'][version].append(item.prepended_detail)
304309
else:
305-
upcoming_breaking_changes[item.module][item.command]['items'].append(item.detail)
310+
upcoming_breaking_changes[item.module][item.command]['items'].append(item.prepended_detail)
306311
return upcoming_breaking_changes
307312

308313

azdev/operations/breaking_change/markdown_template.jinja2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ The breaking changes listed in this article are planned for the next major relea
2121
###{%- if not module == 'core' -%}#{%- endif %} Deprecated in {{ version }}
2222

2323
{% for bc in bcs -%}
24-
- {{ bc.detail }}
24+
{{ bc }}
2525
{% endfor %}
2626

2727
{% endfor -%}
2828
{% else -%}
2929

3030
{% for bc in multi_version_bcs['items'] -%}
31-
- {{ bc }}
31+
{{ bc }}
3232
{% endfor %}
3333

3434
{% endif -%}

0 commit comments

Comments
 (0)