Skip to content

Commit 85212eb

Browse files
authored
Fix sdk module test issue (#28118)
1 parent 2dee6bb commit 85212eb

File tree

2 files changed

+25
-16
lines changed

2 files changed

+25
-16
lines changed

src/Accounts/AssemblyLoading.Test/UnitTests/ConditionalAssemblyProviderTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ namespace Microsoft.Azure.PowerShell.AssemblyLoading.Test.UnitTests
2323
{
2424
public class ConditionalAssemblyProviderTests
2525
{
26-
private const string NetFx = "netfx";
26+
private const string Net45 = "net45";
2727
private const string NetStandard20 = "netstandard2.0";
2828
private const string RootPath = "root";
2929

@@ -44,7 +44,7 @@ public void CanGetAssembliesOnWindowsPowerShell()
4444
Assert.True(assemblies.TryGetValue("Azure.Core", out var azureCore));
4545
Assert.Equal(GetExpectedAssemblyPath(NetStandard20, "Azure.Core"), azureCore.Path);
4646
Assert.True(assemblies.TryGetValue("Newtonsoft.Json", out var newtonsoftJson));
47-
Assert.Equal(GetExpectedAssemblyPath(NetFx, "Newtonsoft.Json"), newtonsoftJson.Path);
47+
Assert.Equal(GetExpectedAssemblyPath(Net45, "Newtonsoft.Json"), newtonsoftJson.Path);
4848

4949
Assert.True(assemblies.TryGetValue("Azure.Identity", out var azureIdentity));
5050
Assert.Equal(GetExpectedAssemblyPath(NetStandard20, "Azure.Identity"), azureIdentity.Path);

tools/BuildScripts/BuildScripts.psm1

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function Get-CsprojFromModule {
66
[string]$Configuration
77
)
88
$renamedModules = @{
9-
'Storage' = @('Storage.Management');
9+
'Storage' = @('Storage.Management')
1010
'DataFactory' = @('DataFactoryV1', 'DataFactoryV2')
1111
}
1212

@@ -62,10 +62,15 @@ function Get-CsprojFromModule {
6262
$result += $testCsproj
6363
}
6464
}
65-
} else {
66-
$testCsproj = Join-Path $SourceDirectory $testModule "$testModule.Test" "$testModule.Test.csproj"
67-
if (Test-Path $testCsproj) {
68-
$result += $testCsproj
65+
}
66+
else {
67+
$testModulePath = Join-Path $SourceDirectory $testModule
68+
$testFolders = Get-ChildItem -Path $testModulePath -Filter *.Test -Directory
69+
if ($null -ne $testFolders) {
70+
$testCsproj = $testFolders | Get-ChildItem -Filter *.Test.csproj -File | Select-Object -ExpandProperty FullName
71+
if (Test-Path $testCsproj) {
72+
$result += $testCsproj
73+
}
6974
}
7075
}
7176
}
@@ -89,17 +94,20 @@ function Invoke-SubModuleGeneration {
8994
$tspLocationPath = Join-Path $GenerateDirectory "tsp-location.yaml"
9095
if (Test-Path $tspLocationPath) {
9196
tsp-client update >> $GenerateLog
92-
} else {
97+
}
98+
else {
9399
if ($IsInvokedByPipeline) {
94100
npx autorest --max-memory-size=8192 >> $GenerateLog
95-
} else {
101+
}
102+
else {
96103
autorest --max-memory-size=8192 >> $GenerateLog
97104
}
98105
}
99106

100107
if ($lastexitcode -ne 0) {
101108
return $false
102-
} else {
109+
}
110+
else {
103111
./build-module.ps1 -DisableAfterBuildTasks
104112
Write-Host "----------End code generation for $GenerateDirectory----------" -ForegroundColor DarkGreen
105113
return $true
@@ -145,15 +153,15 @@ function Update-GeneratedSubModule {
145153
}
146154

147155
if (-not (Invoke-SubModuleGeneration -GenerateDirectory $SourceDirectory -GenerateLog $GenerateLog -IsInvokedByPipeline $IsInvokedByPipeline)) {
148-
return $false;
156+
return $false
149157
}
150158
# remove $sourceDirectory/generated/modules
151159
$localModulesPath = Join-Path $SourceDirectory 'generated' 'modules'
152160
if (Test-Path $localModulesPath) {
153161
Remove-Item -Path $localModulesPath -Recurse -Force
154162
}
155163
$fileToUpdate = @('generated', 'resources', "Az.$subModuleNameTrimmed.psd1", "Az.$subModuleNameTrimmed.psm1", "Az.$subModuleNameTrimmed.format.ps1xml", 'exports', 'internal', 'test-module.ps1', 'check-dependencies.ps1')
156-
# Copy from src/ to generated/
164+
# Copy from src/ to generated/
157165
$fileToUpdate | Foreach-Object {
158166
$moveFrom = Join-Path $SourceDirectory $_
159167
$moveTo = Join-Path $GeneratedDirectory $_
@@ -162,7 +170,7 @@ function Update-GeneratedSubModule {
162170
}
163171
# regenerate csproj
164172
New-GeneratedFileFromTemplate -TemplateName 'Az.ModuleName.csproj' -GeneratedFileName "Az.$subModuleNameTrimmed.csproj" -GeneratedDirectory $GeneratedDirectory -ModuleRootName $ModuleRootName -SubModuleName $subModuleNameTrimmed -SubModuleNameFull $SubModuleName
165-
173+
166174
# revert guid in psd1 so that no conflict in updating this file
167175
if ($guid) {
168176
$psd1Path = Join-Path $GeneratedDirectory "Az.$subModuleNameTrimmed.psd1"
@@ -205,7 +213,8 @@ function New-GeneratedFileFromTemplate {
205213
$templateFile = $templateFile -replace '{LowCaseModuleNamePlaceHolder}', $SubModuleName.ToLower()
206214
if ($SubModuleNameFull) {
207215
$templateFile = $templateFile -replace '{ModuleFolderPlaceHolder}', $SubModuleNameFull
208-
} else {
216+
}
217+
else {
209218
$templateFile = $templateFile -replace '{ModuleFolderPlaceHolder}', "$SubModuleName.Autorest"
210219
}
211220
$templateFile = $templateFile -replace '{RootModuleNamePlaceHolder}', $ModuleRootName
@@ -228,7 +237,7 @@ function New-GenerateInfoJson {
228237
$generateInfoJson["generate_Id"] = $GenerateId
229238
$generateInfoJson | ConvertTo-Json | Set-Content -Path $generateInfoJsonPath -Force
230239
}
231-
else{
240+
else {
232241
Write-Host "Generating generate-info.json file: $generateInfoJsonPath"
233242
$generateInfoJson | Set-Content -Path $generateInfoJsonPath -Force
234243
}
@@ -253,4 +262,4 @@ function Update-MappingJson {
253262
$MappingObject = $MappingObject + @{module = $ModuleName; alias = $ModuleName }
254263
ConvertTo-Json $MappingObject -Depth 1 | Set-Content -Path $MappingPath
255264
}
256-
}
265+
}

0 commit comments

Comments
 (0)