Pickup polishing (4) And Fly Camera (#259)

* Pickups and Fly Camera (this should've been multiple commits)

Pickups:
- better (mostly untested) handling of network pickups and stealing
- max desktop zoop distance
- proper velocity on drop
- use direct transforms setting when Rigidbody reference is null
- dont hover/interact if UI raycast had a UI target
- when non-kinematic pickup disable gravity while held
- only trigger OnInfluenceEnable/Disable if the value changed state

InputModule:
- movement, crouch, jump pause requests (temporary implementation)

Camera:
- fly movement
- inherit from pickup to avoid repetetive code
- camera pinning (handheld, playspace, world)
- force camera preview to stay in front of face on desktop
- lots of camera settings for cinematic style movement

BasisParentConstraint:
- blend quaternions better (little testing of this change done)
- index gaurds

* dont clear influencing on default remote start

* start logic in wrong place after merge, dont set rigid properties if undefined

* added Immobilize, DIsplayName, IsOwnerCached

* added UseJiggles

this allows you to turn of directly the jiggles system

* Fix Merge conflicts + tweaks

- rename interactDisabled to InteractableEnabled
- use OnPickupDown for taking camera photos
- set default interact raycast distance to 5.0
- Use new locking contexts for camera flying
- Scale Camera UI based on player height (base camera object scale is 0.0003 which should be fixed at some point)

* cleanup logs/using

---------

Co-authored-by: dooly <[email protected]>

Author: mriise

Basis/Packages/com.basis.framework/Avatar/BasisAvatarPedestal.cs

@@ -111,7 +111,7 @@ public async void LocalAvatarLoad()
     }
     public override bool CanHover(BasisInput input)
     {
-        return !pickupable &&
+        return InteractableEnabled &&
             !IsPuppeted &&
             Inputs.IsInputAdded(input) &&
             input.TryGetRole(out BasisBoneTrackedRole role) &&
@@ -121,7 +121,7 @@ public override bool CanHover(BasisInput input)
     }
     public override bool CanInteract(BasisInput input)
     {
-        return !pickupable &&
+        return InteractableEnabled &&
             !IsPuppeted &&
             Inputs.IsInputAdded(input) &&
             input.TryGetRole(out BasisBoneTrackedRole role) &&

Basis/Packages/com.basis.framework/Basis Interactions/BasisParentConstraint.cs

@@ -48,45 +48,52 @@ public bool Evaluate(out Vector3 pos, out Quaternion rot)
 
         float totalWeight = 0f;
         Vector3 weightedPos = Vector3.zero;
-        Quaternion weightedRot = Quaternion.identity;
-
-        for (int Index = 0; Index < sources.Length; Index++)
+        Vector4 weightedQuat = Vector4.zero;
+        
+        for (int index = 0; index < sources.Length; index++)
         {
-            ref SourceData source = ref sources[Index];
+            ref SourceData source = ref sources[index];
             if (source.weight <= 0f) continue;
-
-            // pos offset is in local space to the sorce
+            
             Vector3 worldOffset = source.rotation * source.positionOffset;
             weightedPos += (source.position + worldOffset) * source.weight;
-
+            
+            // Rotation - accumulate as 4D vectors
             Quaternion worldRotation = source.rotation * source.rotationOffset;
-            if (totalWeight == 0f)
-            {
-                weightedRot = worldRotation;
-            }
-            else
+            
+            // Ensure quaternions are in same hemisphere (handle q and -q representing same rotation)
+            if (totalWeight > 0f && Vector4.Dot(weightedQuat.normalized, new Vector4(worldRotation.x, worldRotation.y, worldRotation.z, worldRotation.w)) < 0f)
             {
-                weightedRot = Quaternion.Slerp(weightedRot, worldRotation, source.weight / (totalWeight + source.weight));
+                worldRotation = new Quaternion(-worldRotation.x, -worldRotation.y, -worldRotation.z, -worldRotation.w);
             }
-
+            
+            weightedQuat += new Vector4(worldRotation.x, worldRotation.y, worldRotation.z, worldRotation.w) * source.weight;
             totalWeight += source.weight;
         }
-
-        // apply weighted average
+        
+        // Normalize results
         if (totalWeight > 0f)
         {
             weightedPos /= totalWeight;
+            weightedQuat /= totalWeight;
+            
+            // Convert back to quaternion and normalize
+            Quaternion blendedRot = new Quaternion(weightedQuat.x, weightedQuat.y, weightedQuat.z, weightedQuat.w).normalized;
+            
+            // Apply global weight
+            pos = Vector3.Lerp(_restPosition, weightedPos, GlobalWeight);
+            rot = Quaternion.Slerp(_restRotation, blendedRot, GlobalWeight);
+            return true;
         }
-
-        // global weight interpolates original with the calculated transform
-        pos = Vector3.Lerp(_restPosition, weightedPos, GlobalWeight);
-        rot = Quaternion.Slerp(_restRotation, weightedRot, GlobalWeight);
-
-        return true;
+        
+        pos = _restPosition;
+        rot = _restRotation;
+        return false;
     }
 
     public void UpdateSourcePositionAndRotation(int Index, Vector3 position, Quaternion rotation)
     {
+        if (Index < 0 || Index >= sources.Length) return;
         var source = sources[Index];
         source.position = position;
         source.rotation = rotation;
@@ -95,6 +102,7 @@ public void UpdateSourcePositionAndRotation(int Index, Vector3 position, Quatern
 
     public void SetOffsetPositionAndRotation(int Index, Vector3 positionOffset, Quaternion rotationOffset)
     {
+        if (Index < 0 || Index >= sources.Length) return;
         var source = sources[Index];
         source.positionOffset = positionOffset;
         source.rotationOffset = rotationOffset;

Basis/Packages/com.basis.framework/Basis Interactions/InteractableObject.cs

@@ -12,37 +12,39 @@ public abstract class InteractableObject : MonoBehaviour
     [Header("Interactable Settings")]
 
     [SerializeField]
-    private bool disableInfluence = false;
+    private bool interactableEnabled = true;
     // NOTE: unity editor will not use the set function so setting disabling Interact in play will not cleanup inputs
-    public bool pickupable
+    public bool InteractableEnabled
     {
-        get => disableInfluence;
+        get => interactableEnabled;
         set
         {
             // remove hover and interacting on disable
-            if (value)
+            if (!value)
             {
                 ClearAllInfluencing();
-                OnInfluenceDisable?.Invoke();
+                if (interactableEnabled)
+                    OnInfluenceDisable?.Invoke();
             }
             else
             {
-                OnInfluenceEnable?.Invoke();
+                if (!interactableEnabled)
+                    OnInfluenceEnable?.Invoke();
             }
-            disableInfluence = value;
+            interactableEnabled = value;
         }
     }
+
     [Space(10)]
     public bool Equippable = false;
 
     [NonSerialized]
-    public bool RequiresUpdateLoop = false;
+    internal bool RequiresUpdateLoop = false;
+
     /// <summary>
-    /// 1. to block interaction when puppeted.
-    /// 2. (example) iskinematic set
-    /// depending on puppeted state.
+    /// Whether this object is controlled elsewhere.
+    /// This is used to block interaction, set iskinematic, ect.
     /// </summary>
-    // [HideInInspector]
     public bool IsPuppeted = false;
     // Delegates for interaction events
     public Action<BasisInput> OnInteractStartEvent;
@@ -174,6 +176,9 @@ public virtual void OnHoverEnd(BasisInput input, bool willInteract)
         OnHoverEndEvent?.Invoke(input, willInteract);
     }
 
+    /// <summary>
+    /// Interactable event loop, called every frame on AfterFinalMove when an input has it as a target and RequiresUpdateLoop is true.
+    /// </summary>
     public abstract void InputUpdate();
 
     /// <summary>
@@ -207,7 +212,7 @@ public virtual void ClearAllInfluencing()
     /// <returns></returns>
     public virtual bool IsInfluencable(BasisInput input)
     {
-        return !pickupable && (CanHover(input) || CanInteract(input));
+        return InteractableEnabled && (CanHover(input) || CanInteract(input));
     }
 
     public virtual void StartRemoteControl()