Cache overlay traits in ProductionPaletteWidget

Instead of looking this up every Draw tick,
cache and update it only when a non-null new
CurrentQueue is set (as the overlays can only change
at that time).

Author: reaperrr

OpenRA.Mods.Common/Widgets/ProductionPaletteWidget.cs

@@ -101,8 +101,18 @@ public enum ReadyTextStyleOptions { Solid, AlternatingColor, Blinking }
 
 		public ProductionQueue CurrentQueue
 		{
-			get { return currentQueue; }
-			set { currentQueue = value; RefreshIcons(); }
+			get
+			{
+				return currentQueue;
+			}
+			set
+			{
+				currentQueue = value;
+				if (currentQueue != null)
+					UpdateCachedProductionIconOverlays();
+
+				RefreshIcons();
+			}
 		}
 
 		public override Rectangle EventBounds { get { return eventBounds; } }
@@ -115,6 +125,9 @@ public ProductionQueue CurrentQueue
 		SpriteFont overlayFont, symbolFont;
 		float2 iconOffset, holdOffset, readyOffset, timeOffset, queuedOffset, infiniteOffset;
 
+		Player cachedQueueOwner;
+		IProductionIconOverlay[] pios;
+
 		[CustomLintableHotkeyNames]
 		public static IEnumerable<string> LinterHotkeyNames(MiniYamlNode widgetNode, Action<string> emitError, Action<string> emitWarning)
 		{
@@ -225,7 +238,12 @@ public override void Tick()
 				CurrentQueue = null;
 
 			if (CurrentQueue != null)
+			{
+				if (CurrentQueue.Actor.Owner != cachedQueueOwner)
+					UpdateCachedProductionIconOverlays();
+
 				RefreshIcons();
+			}
 		}
 
 		public override void MouseEntered()
@@ -413,6 +431,12 @@ bool SelectProductionBuilding()
 			return true;
 		}
 
+		void UpdateCachedProductionIconOverlays()
+		{
+			cachedQueueOwner = CurrentQueue.Actor.Owner;
+			pios = cachedQueueOwner.PlayerActor.TraitsImplementing<IProductionIconOverlay>().ToArray();
+		}
+
 		public void RefreshIcons()
 		{
 			icons = new Dictionary<Rectangle, ProductionIcon>();
@@ -480,8 +504,6 @@ public override void Draw()
 
 			var buildableItems = CurrentQueue.BuildableItems();
 
-			var pios = currentQueue.Actor.Owner.PlayerActor.TraitsImplementing<IProductionIconOverlay>();
-
 			// Icons
 			Game.Renderer.EnableAntialiasingFilter();
 			foreach (var icon in icons.Values)