Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: redmine/redmine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ChALkeR/redmine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 6, 2013

  1. mailer.rb: Fix message-id generation for outgoing emails. 

    Without this fix, if one configures Redmine to use something like «Redmine <[email protected]>» as the outgoing address
(which works nicely, exept for the message-id), the message-id is set to invalid string like <[email protected]>>
becase of the invalid hostname extraction.
This results in Google ignoring the invalid message-id field and replacing it with an autogenerated one.
The message then fails DKIM check and goes into the spam folder.

This commit fixes invalid message-id generation, and everything works fine for me now.
    @ChALkeR
    ChALkeR committed Sep 6, 2013
    Configuration menu
    Copy the full SHA
    187ba87 View commit details
    Browse the repository at this point in the history
Loading