Skip to content

Commit fff4590

Browse files
authored
Merge pull request #35 from Changaco/fix-broken-test
Fix test broken by libarchive 3.2
2 parents edc5be4 + 185d44e commit fff4590

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

tests/data/unicode2.zip.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"isblk": false,
1111
"isreg": false,
1212
"isfifo": false,
13-
"mode": "rwxrwxrwx",
13+
"mode": null,
1414
"islnk": false,
1515
"ischr": false
1616
},
@@ -25,8 +25,8 @@
2525
"isblk": false,
2626
"isreg": true,
2727
"isfifo": false,
28-
"mode": "rw-rw-rw-",
28+
"mode": null,
2929
"islnk": false,
3030
"ischr": false
3131
}
32-
]
32+
]

tests/test_entry.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,15 @@ def test_check_archiveentry_with_unicode_and_binary_entries_zip():
6868

6969

7070
def test_check_archiveentry_with_unicode_and_binary_entries_zip2():
71-
check_entries(join(data_dir, 'unicode2.zip'))
71+
check_entries(join(data_dir, 'unicode2.zip'), ignore='mode')
7272

7373

7474
def test_check_archiveentry_with_unicode_entries_and_name_zip():
7575
check_entries(join(data_dir, '\ud504\ub85c\uadf8\ub7a8.zip'))
7676

7777

78-
def check_entries(test_file, regen=False):
78+
def check_entries(test_file, regen=False, ignore=''):
79+
ignore = ignore.split()
7980
fixture_file = test_file + '.json'
8081
if regen:
8182
entries = list(get_entries(test_file))
@@ -85,4 +86,7 @@ def check_entries(test_file, regen=False):
8586
expected = json.load(ex)
8687
actual = list(get_entries(test_file))
8788
for e1, e2 in zip(actual, expected):
89+
for key in ignore:
90+
e1.pop(key)
91+
e2.pop(key)
8892
assert e1 == e2

0 commit comments

Comments
 (0)