Fix a bug in SDImageCache making first request to disk cache to always return nil (fix SDWebImage#81)

Olivier Poitrey · Olivier Poitrey · commit a8d5b3ec72a9 · 2012-03-22T10:37:23.000+01:00
diff --git a/SDImageCache.m b/SDImageCache.m
@@ -245,7 +245,7 @@ - (UIImage *)imageFromKey:(NSString *)key fromDisk:(BOOL)fromDisk
 
     if (!image && fromDisk)
     {
-        UIImage *image = SDScaledImageForPath(key, [NSData dataWithContentsOfFile:[self cachePathForKey:key]]);
+        image = SDScaledImageForPath(key, [NSData dataWithContentsOfFile:[self cachePathForKey:key]]);
         if (image)
         {
             [memCache setObject:image forKey:key];

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ - (UIImage )imageFromKey:(NSString )key fromDisk:(BOOL)fromDisk`
`245`	`245`
`246`	`246`	`if (!image && fromDisk)`
`247`	`247`	`{`
`248`		`- UIImage *image = SDScaledImageForPath(key, [NSData dataWithContentsOfFile:[self cachePathForKey:key]]);`
	`248`	`+ image = SDScaledImageForPath(key, [NSData dataWithContentsOfFile:[self cachePathForKey:key]]);`
`249`	`249`	`if (image)`
`250`	`250`	`{`
`251`	`251`	`[memCache setObject:image forKey:key];`