Only create one public route association for s3 endpoint (terraform-aws-modules#73)

steve-dave · antonbabenko · commit 6d7b09167bd5 · 2018-02-09T10:49:25.000+01:00
diff --git a/main.tf b/main.tf
@@ -249,7 +249,7 @@ resource "aws_vpc_endpoint_route_table_association" "private_s3" {
 }
 
 resource "aws_vpc_endpoint_route_table_association" "public_s3" {
-  count = "${var.enable_s3_endpoint ? length(var.public_subnets) : 0}"
+  count = "${var.enable_s3_endpoint ? 1 : 0}"
 
   vpc_endpoint_id = "${aws_vpc_endpoint.s3.id}"
   route_table_id  = "${aws_route_table.public.id}"

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ resource "aws_vpc_endpoint_route_table_association" "private_s3" {`
`249`	`249`	`}`
`250`	`250`
`251`	`251`	`resource "aws_vpc_endpoint_route_table_association" "public_s3" {`
`252`		`- count = "${var.enable_s3_endpoint ? length(var.public_subnets) : 0}"`
	`252`	`+ count = "${var.enable_s3_endpoint ? 1 : 0}"`
`253`	`253`
`254`	`254`	`vpc_endpoint_id = "${aws_vpc_endpoint.s3.id}"`
`255`	`255`	`route_table_id = "${aws_route_table.public.id}"`