-
Notifications
You must be signed in to change notification settings - Fork 10
Credential Query for all Subclasses and to Exclude Classes Are Not Bringing Back Correct Results #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jeannekitchens The query engine looks for a root class's subclasses under the The second query's syntax is wrong, the correct query would be: {
"@type": {
"search:value": "ceterms:Credential",
"search:matchType": "search:subClassOf"
},
"!@type": "ceterms:QACredential"
} But this one won't work either because the mapping is outdated. |
@mparsons-ce are you handling updating of the Registry config for adding subclasses. Per above comment from @excelsior it needs to be updated and the mapping is outdated. @excelsior this is definitely a problem as the first thing that comes to my mind is that consumers are missing thousands of credentials. I need to know exactly what needs to happen so the three queries work dependably that caused this issue. @rohit-joy @chuang-CE tagging you for awareness. I would think the CLLC Registry also has a configuration that has to be maintained. |
@excelsior does not have the property: subsclasses_map. |
@excelsior @edgarf we need to know how the config file referenced above by @excelsior is created/updated. If it relies on manual updates that seems problematic also because we didn't know it was needed. The queries are simple and were previously verified to work...according to closed Github issues. |
@mparsons-ce I added the default mapping into the default config: Please let me know one the actual config is updated with the up-to-date mapping so I can make sure the subclasses are resolved correctly. |
@excelsior I am adding the subclasses to the config file that I have been using. I see the subclasses are not up to date either, based on: |
@excelsior The config file that I was using did NOT have the following section: For the subclasses |
@excelsior Another question what about for custom communities like for Florida (fdoe)? "id_prefix": "http://credentialengineregistry.org/resources/", |
@excelsior Just as a test, I updated the sandbox with the updated config file.
It didn't include AcademicCertificate. This was one of the classes that was missing from the config file in github. |
No, it isn't used in the app.
Same as above, not used, so it doesn't really matter.
I'm looking at the current config (retrieved via |
@excelsior If the latter looks OK, I can go ahead and update production. |
@mparsons-ce The changes look good indeed. Please update the production config the same way. |
@excelsior I have updated production. |
@jeannekitchens @mparsons-ce I checked the query results after Mike updated the config, and now the original query returns slightly more data than you'd expect.
returns 104,463.
returns 104,448.
returns 15, which is If 102,796 the correct number of credentials, I'll try to find out where does this discrepancy come from. |
@excelsior thank you. The registry counts are a moving target. New data is published almost daily so it is very possible that the quantity increased. Also, we account for blank nodes with the Finder making is somewhat confusing to verify counts. We need to double check a couple things on our end. What had to be manually changed to correct this? Is this something that is programatically updated or manually updated? |
@mparsons-ce Can you implement the suggestions implemented by @jeannekitchens so we can bring a closure to this issue now that record counts are back up to the expectations ? |
@jeannekitchens No manual adjustments are required. |
@excelsior & @mparsons-ce Can this issue be closed now?.. |
Closing this issue after creating #841 for documenting the configuration steps. |
At the time of writing this, there's, 102,796 credentials published to the Registry across Credential Classes. See the full list of Credential Classes https://credreg.net/ctdl/handbook#credentialclasses. This is a query I need a customer to use but I cannot provide the information to them because neither query works.
The query below should bring back all 102,696 credentials. However, it only brings back 97,738 credentials.
{
"@type": {
"search:value": "ceterms:Credential",
"search:matchType": "search:subClassOf"
}
}
This query is supposed to exclude the Credential Class QACredential. However, it does not work. It brings back 97,738 credentials. The "search:notValue" does not work.
{
"@type": {
"search:value": "ceterms:Credential",
"search:matchType": "search:subClassOf",
"search:notValue": "ceterms:QACredential"
}
}
The text was updated successfully, but these errors were encountered: