Skip to content

Indexer refetches json_context when properties are missing and fails the indexing job if it can't be fetched by default #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chuang-CE opened this issue Jun 4, 2025 · 4 comments
Closed

Indexer refetches json_context when properties are missing and fails the indexing job if it can't be fetched by default #830

chuang-CE opened this issue Jun 4, 2025 · 4 comments
Assignees
@excelsior @arielr-lt @chuang-CE
Labels
Blocker bug High Priority

Comments

@chuang-CE
Copy link
Collaborator

Indexer shouldn't fail envelopes that have missing contexts, rather just log it and move on since some properties are meant to be skipped if skip_validation is true.
excelsior added a commit that referenced this issue Jun 5, 2025
@excelsior
(#830) Ignore unreachable context URLs when indexing
d0c6a5d
@excelsior
Copy link
Collaborator

@chuang-CE The fix is ready for QA. It's in a separate branch in the CLLC repo.

excelsior added a commit that referenced this issue Jun 5, 2025
@excelsior
(#830) Ignore unreachable context URLs when indexing
540a310
@khasan786
Copy link
Collaborator

@chuang-CE Can you please test and validate the fix?..

@chuang-CE
Copy link
Collaborator Author

Tested and validated.

@excelsior excelsior mentioned this issue Jun 7, 2025
Merged
@excelsior
Copy link
Collaborator

@chuang-CE Please approve the PR please.

chuang-CE pushed a commit that referenced this issue Jun 10, 2025
@excelsior
(#830) Ignore unreachable context URLs when indexing (#831)
65c8dbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@excelsior excelsior

@arielr-lt arielr-lt

@chuang-CE chuang-CE

Labels
Blocker bug High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@excelsior @jeannekitchens @arielr-lt @chuang-CE @khasan786