Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iCamilo/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Cronay/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 4 files changed
  • 1 contributor

Commits on Aug 20, 2020

  1. When loading, guarantee that client is used to perform request from t… 

    …he specified URL
    @Cronay
    Cronay committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    5dd8f37 View commit details
    Browse the repository at this point in the history

  2. When loading, call completion with an failure result passing a connec… 

    …tivity error
    @Cronay
    Cronay committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    6b48fef View commit details
    Browse the repository at this point in the history

  3. When loading, complete with failure result and an invalidData error i… 

    …f the statusCode from the received HTTPURLResponse is not 200
    @Cronay
    Cronay committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    047f3d6 View commit details
    Browse the repository at this point in the history

  4. When loading, complete with failure result and error invalid data whe… 

    …n response is valid but data is not
    @Cronay
    Cronay committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    a4720a0 View commit details
    Browse the repository at this point in the history

  5. Made FeedImage conform to Codable protocol in order to parse feed i… 

    …mages from JSON Data
    @Cronay
    Cronay committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    716798c View commit details
    Browse the repository at this point in the history

  6. When the json parsing succeeds return an empty list of feed images

    @Cronay
    Cronay committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    1756ee4 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Added coding keys to FeedImage in order to be able to parse them fr… 

    …om the json payload
    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    a846090 View commit details
    Browse the repository at this point in the history

  2. Use the result of the JSONDecoder and pass that to the success result

    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    5e7cb76 View commit details
    Browse the repository at this point in the history

  3. Removed API details about names of objects in json from model `FeedIm… 

    …age` by creating an intermediate struct `Item` containing the API Details which is parsed from json
    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    8693b4c View commit details
    Browse the repository at this point in the history

  4. Introduced the FeedImageMapper to simplify switch statement within … 

    …the load method of the `RemoteFeedLoader`
    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9a6826d View commit details
    Browse the repository at this point in the history

  5. Move the FeedImageMapper to its own file and restrict the Item an… 

    …d `Root` classes to its scope
    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    992feea View commit details
    Browse the repository at this point in the history

  6. Made FeedImageMapper a final class, made it internal and removed pu… 

    …blic access to `Item` struct
    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9aaf732 View commit details
    Browse the repository at this point in the history

  7. Added a nil check for self in RemoteFeedLoader in order to guarante… 

    …e to not invoke completion closure when instance has been deallocated
    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    ed06ade View commit details
    Browse the repository at this point in the history

  8. Added Result typealias to RemoteFeedLoader so we can use it in the … 

    …`FeedImageMapper`, to prevent referencing the FeedLoader Module directly from there
    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b7719ec View commit details
    Browse the repository at this point in the history

  9. Move the rest of the mapping logic within RemoteFeedLoader to the `… 

    …FeedImageMapper`
    @Cronay
    Cronay committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    23e643d View commit details
    Browse the repository at this point in the history
Loading