Skip to content

Commit 56ca569

Browse files
committed
tests: don't add the same USB devices to the guest twice
Libvirt now validates that all <hostdev> elements refer to distinct host devices. The test suite violates that constraint by trying to build a new guest with the same USB devices added to the guest twice, to validate the various host device syntax options. Signed-off-by: Daniel P. Berrangé <[email protected]>
1 parent cfa8860 commit 56ca569

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/data/cli/compare/virt-install-many-devices.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -571,15 +571,15 @@
571571
</hostdev>
572572
<hostdev mode="subsystem" type="usb" managed="yes">
573573
<source>
574-
<vendor id="0x0781"/>
575-
<product id="0x5151"/>
574+
<vendor id="0x062a"/>
575+
<product id="0x0001"/>
576576
</source>
577577
<driver name="vfio"/>
578578
</hostdev>
579579
<hostdev mode="subsystem" type="usb" managed="yes">
580580
<source>
581-
<vendor id="0x04b3"/>
582-
<product id="0x4485"/>
581+
<vendor id="0x0483"/>
582+
<product id="0x2016"/>
583583
</source>
584584
</hostdev>
585585
<hostdev mode="subsystem" type="scsi" managed="no">

tests/test_cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -695,8 +695,8 @@ def add_compare(self, cat, args, compbase, **kwargs):
695695
--hostdev 15:0.1
696696
--host-device 2:15:0.2
697697
--hostdev 0:15:0.3,address.type=pci,address.zpci.uid=0xffff,address.zpci.fid=0xffffffff
698-
--host-device 0x0781:0x5151,driver_name=vfio
699-
--host-device 04b3:4485
698+
--host-device 0x062a:0x0001,driver_name=vfio
699+
--host-device 0483:2016
700700
--host-device pci_8086_2829_scsi_host_scsi_device_lun0,rom.bar=on
701701
--hostdev usb_5_20 --hostdev usb_5_21
702702
--hostdev wlan0,type=net

0 commit comments

Comments
 (0)