Version 2.11.0-264.0.dev

Merge commit '6cee3b5fe121039aa4f6bd9b9a9a50c74a2c06bd' into 'dev'

Author: Dart CI

.dart_tool/package_config.json

@@ -11,7 +11,7 @@
     "constraint, update this by running tools/generate_package_config.dart."
   ],
   "configVersion": 2,
-  "generated": "2020-10-20T23:33:25.579167",
+  "generated": "2020-10-26T09:42:07.748397",
   "generator": "tools/generate_package_config.dart",
   "packages": [
     {
@@ -150,6 +150,12 @@
       "packageUri": "lib/",
       "languageVersion": "2.0"
     },
+    {
+      "name": "clock",
+      "rootUri": "../third_party/pkg/clock",
+      "packageUri": "lib/",
+      "languageVersion": "2.10"
+    },
     {
       "name": "collection",
       "rootUri": "../third_party/pkg/collection",
@@ -332,7 +338,7 @@
       "name": "intl",
       "rootUri": "../third_party/pkg/intl",
       "packageUri": "lib/",
-      "languageVersion": "2.5"
+      "languageVersion": "2.11"
     },
     {
       "name": "js",
@@ -509,12 +515,6 @@
       "packageUri": "lib/",
       "languageVersion": "2.0"
     },
-    {
-      "name": "quiver",
-      "rootUri": "../third_party/pkg/quiver",
-      "packageUri": "lib/",
-      "languageVersion": "2.0"
-    },
     {
       "name": "resource",
       "rootUri": "../third_party/pkg/resource",

.packages

@@ -79,7 +79,6 @@ pool:third_party/pkg/pool/lib
 protobuf:third_party/pkg/protobuf/protobuf/lib
 pub:third_party/pkg/pub/lib
 pub_semver:third_party/pkg/pub_semver/lib
-quiver:third_party/pkg/quiver/lib
 resource:third_party/pkg/resource/lib
 sdk_library_metadata:sdk/lib/_internal/sdk_library_metadata/lib
 shelf:third_party/pkg/shelf/lib

CHANGELOG.md

@@ -4,8 +4,14 @@
 
 #### `dart:io`
 
-*   `HttpRequest` will now correctly follow HTTP 308 redirects
-    (`HttpStatus.permanentRedirect`).
+* `HttpRequest` will now correctly follow HTTP 308 redirects
+  (`HttpStatus.permanentRedirect`).
+
+#### `dart:isolate`
+
+* Added `debugName` positional parameter to `ReceivePort` and `RawReceivePort`
+  constructors, a name which can be associated with the port and displayed in
+  tooling.
 
 ### Dart VM
 

DEPS

@@ -76,6 +76,7 @@ vars = {
   "charcode_rev": "bcd8a12c315b7a83390e4865ad847ecd9344cba2",
   "chrome_rev" : "19997",
   "cli_util_rev" : "335ed165887d0ec97c2a09173ebf22dcf56a6c4e",
+  "clock_rev" : "a494269254ba978e7ef8f192c5f7fec3fc05b9d3",
   "collection_rev": "60e6ee2228586980826b07ec1df633bd879f42ea",
   "convert_rev": "c1b01f832835d3d8a06b0b246a361c0eaab35d3c",
   "crypto_rev": "f7c48b334b1386bc5ab0f706fbcd6df8496a87fc",
@@ -110,7 +111,7 @@ vars = {
   "http_throttle_tag" : "1.0.2",
   "icu_rev" : "79326efe26e5440f530963704c3c0ff965b3a4ac",
   "idl_parser_rev": "5fb1ebf49d235b5a70c9f49047e83b0654031eb7",
-  "intl_tag": "0.16.1",
+  "intl_tag": "0.17.0-nullsafety",
   "jinja2_rev": "2222b31554f03e62600cd7e383376a7c187967a1",
   "json_rpc_2_rev": "8f189db8f0c299187a0e8fa959dba7e9b0254be5",
   "linter_tag": "0.1.121",
@@ -312,6 +313,8 @@ deps = {
       Var("dart_git") + "charcode.git" + "@" + Var("charcode_rev"),
   Var("dart_root") + "/third_party/pkg/cli_util":
       Var("dart_git") + "cli_util.git" + "@" + Var("cli_util_rev"),
+  Var("dart_root") + "/third_party/pkg/clock":
+      Var("dart_git") + "clock.git" + "@" + Var("clock_rev"),
   Var("dart_root") + "/third_party/pkg/collection":
       Var("dart_git") + "collection.git" + "@" + Var("collection_rev"),
   Var("dart_root") + "/third_party/pkg/convert":

pkg/analyzer/lib/src/pubspec/pubspec_validator.dart

@@ -5,6 +5,7 @@
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/file_system/file_system.dart';
+import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/pubspec/pubspec_warning_code.dart';
 import 'package:path/path.dart' as path;
@@ -204,6 +205,12 @@ class PubspecValidator {
   }
 
   /// Validate that `path` entries reference valid paths.
+  ///
+  /// Valid paths are directories that:
+  ///
+  /// 1. exist,
+  /// 2. contain a pubspec.yaml file, and
+  /// 3. `lib` dir
   void _validatePathEntries(ErrorReporter reporter, YamlNode dependency) {
     if (dependency is YamlMap) {
       for (var node in dependency.nodes.entries) {
@@ -214,9 +221,18 @@ class PubspecValidator {
           var packageRoot = context.dirname(source.fullName);
           var dependencyPath =
               path.canonicalize(context.join(packageRoot, normalizedPath));
-          if (!provider.getFolder(dependencyPath).exists) {
+          var packageFolder = provider.getFolder(dependencyPath);
+          if (!packageFolder.exists) {
             _reportErrorForNode(reporter, node.value,
                 PubspecWarningCode.PATH_DOES_NOT_EXIST, [pathEntry]);
+          } else {
+            if (!packageFolder
+                .getChild(AnalysisEngine.PUBSPEC_YAML_FILE)
+                .exists) {
+              _reportErrorForNode(reporter, node.value,
+                  PubspecWarningCode.PATH_PUBSPEC_DOES_NOT_EXIST, [pathEntry]);
+            }
+            // todo (pq): test for presence of a lib dir.
           }
         }
       }

pkg/analyzer/lib/src/pubspec/pubspec_warning_code.dart

@@ -72,6 +72,17 @@ class PubspecWarningCode extends ErrorCode {
       correction:
           "Try creating the referenced path or using a path that exists.");
 
+  /// A code indicating that a specified path dependency points to a directory
+  /// that does not contain a pubspec.
+  ///
+  /// Parameters:
+  /// 0: the path to the dependency as given in the file.
+  static const PubspecWarningCode PATH_PUBSPEC_DOES_NOT_EXIST = PubspecWarningCode(
+      'PATH_PUBSPEC_DOES_NOT_EXIST',
+      "The directory {0} does not contain a pubspec.",
+      correction:
+          "Try creating a pubspec in the referenced directory or using a path that has a pubspec.");
+
   /// A code indicating that a package listed as a dev dependency is also listed
   /// as a normal dependency.
   ///

pkg/analyzer/test/src/pubspec/pubspec_validator_test.dart

@@ -49,7 +49,7 @@ class PubspecValidatorTest with ResourceProviderMixin {
     validator = PubspecValidator(resourceProvider, source);
   }
 
-  test_assetDirectoryDoesExists_noError() {
+  test_assetDirectoryDoesExist_noError() {
     newFolder('/sample/assets/logos');
     assertNoErrors('''
 name: sample
@@ -208,17 +208,21 @@ dependencies:
 ''');
   }
 
-  test_dependencyPathDoesNotExist_path_error() {
+  test_dependencyPath_pubspecDoesNotExist() {
+    newFolder('/foo');
     assertErrors('''
 name: sample
 dependencies:
   foo:
-    path: does/not/exist
-''', [PubspecWarningCode.PATH_DOES_NOT_EXIST]);
+    path: /foo
+''', [PubspecWarningCode.PATH_PUBSPEC_DOES_NOT_EXIST]);
   }
 
-  test_dependencyPathExists() {
+  test_dependencyPath_pubspecExists() {
     newFolder('/foo');
+    newFile('/foo/pubspec.yaml', content: '''
+name: foo
+''');
     assertNoErrors('''
 name: sample
 dependencies:
@@ -227,8 +231,24 @@ dependencies:
 ''');
   }
 
-  test_dependencyPathRelativeExists() {
+  test_dependencyPath_valid_absolute() {
     newFolder('/foo');
+    newFile('/foo/pubspec.yaml', content: '''
+name: foo
+''');
+    assertNoErrors('''
+name: sample
+dependencies:
+  foo:
+    path: /foo
+''');
+  }
+
+  test_dependencyPath_valid_relative() {
+    newFolder('/foo');
+    newFile('/foo/pubspec.yaml', content: '''
+name: foo
+''');
     assertNoErrors('''
 name: sample
 dependencies:
@@ -237,6 +257,15 @@ dependencies:
 ''');
   }
 
+  test_dependencyPathDoesNotExist_path_error() {
+    assertErrors('''
+name: sample
+dependencies:
+  foo:
+    path: does/not/exist
+''', [PubspecWarningCode.PATH_DOES_NOT_EXIST]);
+  }
+
   test_devDependenciesField_empty() {
     assertNoErrors('''
 name: sample
@@ -270,6 +299,9 @@ dev_dependencies:
 
   test_devDependencyPathExists() {
     newFolder('/foo');
+    newFile('/foo/pubspec.yaml', content: '''
+name: foo
+''');
     assertNoErrors('''
 name: sample
 dev_dependencies:

pkg/analyzer_cli/pubspec.yaml

@@ -6,8 +6,9 @@ publish_to: none
 
 environment:
   sdk: "^2.7.0"
+
 dependencies:
-  analyzer: ^0.37.0
+  analyzer: any
   args: '>=0.13.0 <2.0.0'
   bazel_worker: ^0.1.0
   collection: ^1.14.1
@@ -17,8 +18,13 @@ dependencies:
   path: any
   pub_semver: ^1.4.2
   yaml: ^2.1.2
+
 dev_dependencies:
   pedantic: ^1.9.0
   protobuf: ^0.13.0
   test_reflective_loader: ^0.1.8
   test: ^1.0.0
+
+dependency_overrides:
+  analyzer:
+    path: ../analyzer

pkg/async_helper/pubspec.yaml

@@ -1,11 +1,17 @@
 name: async_helper
 # This package is not intended for consumption on pub.dev. DO NOT publish.
 publish_to: none
+
 description: >-
  Async_helper is used for asynchronous tests that do not want to
  make use of the Dart unittest library - for example, the core
  language tests.
  Third parties are discouraged from using this, and should use
  the facilities provided in package:test.
+
+environment:
+  sdk: '>=2.0.0'
+
 dependencies:
-  expect: any
+  expect:
+    path: ../expect

pkg/build_integration/pubspec.yaml

@@ -9,7 +9,11 @@ environment:
   sdk: '>=2.1.0 <3.0.0'
 
 dependencies:
-  front_end: ^0.1.0
+  front_end: any
 
 dev_dependencies:
   test: any
+
+dependency_overrides:
+  front_end:
+    path: ../front_end