isFinite: use && to avoid a ShortCircuitBoolean warning; if there really is benefit to & that could be benchmarked/justified in the future.

kevinb · cpovirk · commit 0ed25bcc1394 · 2017-04-06T11:46:11.000-07:00
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=152292580
diff --git a/guava/src/com/google/common/primitives/Doubles.java b/guava/src/com/google/common/primitives/Doubles.java
@@ -103,7 +103,7 @@ public static int compare(double a, double b) {
    * @since 10.0
    */
   public static boolean isFinite(double value) {
-    return NEGATIVE_INFINITY < value & value < POSITIVE_INFINITY;
+    return NEGATIVE_INFINITY < value && value < POSITIVE_INFINITY;
   }
 
   /**
diff --git a/guava/src/com/google/common/primitives/Floats.java b/guava/src/com/google/common/primitives/Floats.java
@@ -99,7 +99,7 @@ public static int compare(float a, float b) {
    * @since 10.0
    */
   public static boolean isFinite(float value) {
-    return NEGATIVE_INFINITY < value & value < POSITIVE_INFINITY;
+    return NEGATIVE_INFINITY < value && value < POSITIVE_INFINITY;
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public static int compare(double a, double b) {`
`103`	`103`	`* @since 10.0`
`104`	`104`	`*/`
`105`	`105`	`public static boolean isFinite(double value) {`
`106`		`- return NEGATIVE_INFINITY < value & value < POSITIVE_INFINITY;`
	`106`	`+ return NEGATIVE_INFINITY < value && value < POSITIVE_INFINITY;`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public static int compare(float a, float b) {`
`99`	`99`	`* @since 10.0`
`100`	`100`	`*/`
`101`	`101`	`public static boolean isFinite(float value) {`
`102`		`- return NEGATIVE_INFINITY < value & value < POSITIVE_INFINITY;`
	`102`	`+ return NEGATIVE_INFINITY < value && value < POSITIVE_INFINITY;`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`/**`