Duration parsing dependent from current time, fix graphhopper#588

Author: Peter

core/src/main/java/com/graphhopper/reader/OSMTagParser.java

@@ -28,6 +28,9 @@
  */
 public class OSMTagParser
 {
+    // Calendar cal = Calendar.getInstance();cal.set(2015, 11, 1); cal.getTimeInMillis(), see #588
+    private final static Date STATIC_DATE = new Date(1448924400000L);
+
     /**
      * Parser according to http://wiki.openstreetmap.org/wiki/Key:duration The value consists of a
      * string ala 'hh:mm', format for hours and minutes 'mm', 'hh:mm' or 'hh:mm:ss', or
@@ -50,7 +53,7 @@ public static long parseDuration( String str ) throws IllegalArgumentException
             try
             {
                 dur = DatatypeFactory.newInstance().newDuration(str);
-                seconds = dur.getTimeInMillis(new Date()) / 1000;
+                seconds = dur.getTimeInMillis(STATIC_DATE) / 1000;
             } catch (Exception ex)
             {
                 throw new IllegalArgumentException("Cannot parse duration tag value: " + str, ex);

core/src/test/java/com/graphhopper/reader/OSMTagParserTest.java

@@ -30,7 +30,7 @@ public class OSMTagParserTest
 {
     @Test
     public void testParseDuration()
-    {
+    {        
         assertEquals(10 * 60, OSMTagParser.parseDuration("00:10"));
         assertEquals(35 * 60, OSMTagParser.parseDuration("35"));
         assertEquals(70 * 60, OSMTagParser.parseDuration("01:10"));
@@ -40,11 +40,8 @@ public void testParseDuration()
         assertEquals(20 * 60, OSMTagParser.parseDuration("0:20:00"));
         assertEquals((60 * 2 + 20) * 60 + 2, OSMTagParser.parseDuration("02:20:02"));
 
-        // two months, see #588
-        // 28+31
-        assertTrue(2 * 28 * 24 * 60 * 60 <= OSMTagParser.parseDuration("P2M"));
-        // 31+31
-        assertTrue(2 * 31 * 24 * 60 * 60 >= OSMTagParser.parseDuration("P2M"));
+        // two months
+        assertEquals(31 + 31, OSMTagParser.parseDuration("P2M") / (24 * 60 * 60));
 
         // two minutes
         assertEquals(2 * 60, OSMTagParser.parseDuration("PT2M"));