Skip to content

Associated constant visibility is broken #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tritao opened this issue Dec 4, 2024 · 0 comments · Fixed by #6785
Closed

Associated constant visibility is broken #6772

tritao opened this issue Dec 4, 2024 · 0 comments · Fixed by #6785
Assignees
@tritao
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen team:compiler Compiler Team

Comments

@tritao
Copy link
Contributor

tritao commented Dec 4, 2024 

library;

pub struct I8 {
    underlying: u8,
}

impl I8 {
    const MIN: Self = Self {
        underlying: u8::min(),
    };
}

trait Foo {
    fn foo();
}

impl Foo for I8 {
    fn foo() {
        let x = Self::MIN;
        log(x);
    }
}

https://github.com/SwayStar123/private_associated_const_repro
@tritao tritao added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Dec 4, 2024
@tritao tritao self-assigned this Dec 4, 2024
@tritao tritao mentioned this issue Dec 11, 2024
Merged
8 tasks
@tritao tritao changed the title Undiagnosed issue with associated constant Associated constant visibility is broken Dec 17, 2024
@IGI-111 IGI-111 added the team:compiler Compiler Team label Feb 10, 2025
tritao added a commit that referenced this issue Apr 30, 2025
@tritao
Rework and fix associated const visibility for impl items (#6785)
d258921 
## Description

Fixes #6772.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritao tritao

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen team:compiler Compiler Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework and fix associated const visibility for impl items tritao/sway
2 participants
@tritao @IGI-111