Skip to content

Commit 77c4968

Browse files
committed
code style
1 parent 3369f45 commit 77c4968

File tree

3 files changed

+43
-56
lines changed

3 files changed

+43
-56
lines changed

src/main/scala/de/htwg/scalala/advancedDsl/Main.scala

Lines changed: 40 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -12,58 +12,62 @@ object Main {
1212
| instrument Marimba
1313
| plays chord(c,d,e)
1414
|
15-
|musician guitar_1
16-
| instrument Guitar
17-
| plays loop(a,b)
18-
|
19-
|musician drummer_1
20-
| instrument Drum
21-
| plays loop(HiHatClosed)
22-
|
2315
|play with tempo 50
2416
| piano_1,
2517
| marimba_1 at 12,
26-
| marimba_1 at 7,
27-
| guitar_1,
28-
| drummer_1
18+
| marimba_1 at 7
2919
""".stripMargin
3020

3121
val in2 =
32-
"""musician piano_1
22+
"""musician piano_left
3323
| instrument Piano
34-
| plays c,d
24+
| plays d,a,h,a,d,a,d,a,h,d,h,d,a
25+
|
26+
|musician piano_right
27+
| instrument Piano
28+
| plays d/16,e/16,f.sharp,a,f.sharp,e/8,d.dot / 2,f.sharp,a/8,chord(d,g,h),d/8,c,a,chord(a,d/2,c.sharp / 2)
3529
|
3630
|play with tempo 50
37-
| pi
31+
| piano_left,
32+
| piano_right
3833
""".stripMargin
3934

40-
//parse(in)
41-
autoComplete(in2)
35+
val in3 =
36+
"""musician piano_1
37+
| instrument Piano
38+
| plays c,c.sharp,c.flat,c.dot,c/2,c/4,c/8,c/16, c.sharp/2,chord(c.sharp,d.flat),c,+c,-c,++c,--c
39+
|
40+
|play with tempo 30
41+
| piano_1
42+
""".stripMargin
43+
44+
parse(in3)
45+
//autoComplete(in3)
4246
}
4347

44-
def parse(inputStr: String) = {
45-
val parser = new Reader
46-
parser.parseAll(parser.song, inputStr) match {
47-
case parser.Success(r, n) => {
48-
println("Success:")
49-
println(r)
48+
def parse(inputStr: String) = {
49+
val parser = new Reader
50+
parser.parseAll(parser.song, inputStr) match {
51+
case parser.Success(r, n) => {
52+
println("Success:")
53+
println(r)
5054

51-
val interpreter = new Interpreter(r)
52-
try {
53-
interpreter.run
54-
} catch {
55-
case e: RuntimeException => println("Error: " + e.printStackTrace())
56-
}
55+
val interpreter = new Interpreter(r)
56+
try {
57+
interpreter.run
58+
} catch {
59+
case e: RuntimeException => println("Error: " + e.printStackTrace())
5760
}
58-
case parser.Error(msg, n) => println("Error: " + msg)
59-
case parser.Failure(msg, n) => println("Error: " + msg)
60-
case _ =>
6161
}
62+
case parser.Error(msg, n) => println("Error: " + msg)
63+
case parser.Failure(msg, n) => println("Error: " + msg)
64+
case _ =>
6265
}
66+
}
6367

64-
def autoComplete(inputStr: String) = {
65-
val parserAC = new ReaderAutoComplete
66-
val autoComp = parserAC.autoCompletion(parserAC.song, inputStr)
67-
println(autoComp)
68-
}
68+
def autoComplete(inputStr: String) = {
69+
val parserAC = new ReaderAutoComplete
70+
val autoComp = parserAC.autoCompletion(parserAC.song, inputStr)
71+
println(autoComp)
72+
}
6973
}

src/main/scala/de/htwg/scalala/advancedDsl/Note.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@ case class Note(name: String, accidental: String = "", duration: Int = 0, octave
3030
case "+" => n = n +
3131
case "-" => n = n -
3232
}
33-
n.ticks(if (duration > 0) 16/duration else 16)
33+
n.ticks(if (duration > 0) 16 / duration else 16)
3434
}
3535
}

src/main/scala/de/htwg/scalala/advancedDsl/Reader.scala

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,15 @@ class Reader extends StandardTokenParsers {
1414
"plays",
1515
"tempo",
1616
"at",
17-
"c" , "d" , "e" , "f" , "g" , "a" , "h",
17+
"c", "d", "e", "f", "g", "a", "h",
1818
"2", "4", "8", "16",
19-
"sharp", "flat", "dot"
20-
)
19+
"sharp", "flat", "dot")
2120
lexical.delimiters += (",", "(", ")", "/", ".", "+", "-")
2221

23-
2422
def song: Parser[Song] = rep(musician | track) ^^ {
2523
s => new Song(s)
2624
}
2725

28-
29-
3026
def musician: Parser[Musician] = ("musician" ~> ident) ~ ("instrument" ~> instrument) ~ ("plays" ~> (loopElements | noteElements)) ^^ {
3127
case m ~ i ~ e => new Musician(m, i, e)
3228
}
@@ -36,8 +32,6 @@ class Reader extends StandardTokenParsers {
3632
case p ~ t ~ m => new Track(m, t.get)
3733
}
3834

39-
40-
4135
def instrument: Parser[Instrument] = ident ^^ {
4236
case i => new Instrument(i)
4337
}
@@ -50,8 +44,6 @@ class Reader extends StandardTokenParsers {
5044
case l => new LoopElement(l)
5145
}
5246

53-
54-
5547
def tempo: Parser[Int] = "with" ~> "tempo" ~> numericLit ^^ {
5648
n => n.toInt
5749
}
@@ -60,8 +52,6 @@ class Reader extends StandardTokenParsers {
6052
m => m
6153
}
6254

63-
64-
6555
def noteElement: Parser[NoteElement] = chord | note ^^ {
6656
e => e
6757
}
@@ -75,8 +65,6 @@ class Reader extends StandardTokenParsers {
7565
n => n.toInt
7666
}
7767

78-
79-
8068
def note: Parser[Note] = opt(octave) ~ ("c" | "d" | "e" | "f" | "g" | "a" | "h") ~ opt("." ~> accidental) ~ opt("/" ~> duration) ^^ {
8169
case o ~ n ~ a ~ d => new Note(n, a.getOrElse(""), d.getOrElse(0), o.getOrElse(List[String]()))
8270
}
@@ -85,8 +73,6 @@ class Reader extends StandardTokenParsers {
8573
case n => new Chord(n)
8674
}
8775

88-
89-
9076
def octave: Parser[List[String]] = rep("+" | "-") ^^ {
9177
o => o
9278
}
@@ -99,9 +85,6 @@ class Reader extends StandardTokenParsers {
9985
d => d.toInt
10086
}
10187

102-
103-
104-
10588
def parseAll[T](p: Parser[T], in: String): ParseResult[T] = {
10689
phrase(p)(new lexical.Scanner(in))
10790
}

0 commit comments

Comments
 (0)