Fix rstudio#725: Tabs with icons give incorrect values

When no explicit value argument was present on tabPanel,
the inner text of the HTML anchor was used. This gave
weird results when an icon was used, since it appears in
the anchor.

The fix is to always use the value parameter, defaulting
it to the title.

Author: jcheng5

R/bootstrap.R

@@ -1404,7 +1404,7 @@ dateRangeInput <- function(inputId, label, start = NULL, end = NULL,
 #'   )
 #' )
 #' @export
-tabPanel <- function(title, ..., value = NULL, icon = NULL) {
+tabPanel <- function(title, ..., value = title, icon = NULL) {
   divTag <- div(class="tab-pane",
                 title=title,
                 `data-value`=value,

man/tabPanel.Rd

@@ -4,7 +4,7 @@
 \alias{tabPanel}
 \title{Create a tab panel}
 \usage{
-tabPanel(title, ..., value = NULL, icon = NULL)
+tabPanel(title, ..., value = title, icon = NULL)
 }
 \arguments{
 \item{title}{Display title for tab}