Merge pull request udacity#63 from ggmartins/master

SudKul · web-flow · commit 8262e689cde6 · 2022-01-17T16:54:26.000+05:30
fix: parseInt of urlExpiration + xray:PutTraceSegments perm for getImages
diff --git a/course-04/exercises/lesson-4/solution/src/lambda/http/createImage.ts b/course-04/exercises/lesson-4/solution/src/lambda/http/createImage.ts
@@ -88,6 +88,6 @@ function getUploadUrl(imageId: string) {
   return s3.getSignedUrl('putObject', {
     Bucket: bucketName,
     Key: imageId,
-    Expires: urlExpiration
+    Expires: parseInt(urlExpiration)
   })
 }
diff --git a/course-04/exercises/lesson-6/starter-code/serverless.yml b/course-04/exercises/lesson-6/starter-code/serverless.yml
@@ -157,6 +157,10 @@ functions:
         Action:
           - dynamodb:GetItem
         Resource: arn:aws:dynamodb:${self:provider.region}:*:table/${self:provider.environment.GROUPS_TABLE}
+      - Effect: Allow
+        Action:
+        - xray:PutTraceSegments
+        Resource: "*"
 
   CreateImage:
     handler: src/lambda/http/createImage.handler

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,6 @@ function getUploadUrl(imageId: string) {`
`88`	`88`	`return s3.getSignedUrl('putObject', {`
`89`	`89`	`Bucket: bucketName,`
`90`	`90`	`Key: imageId,`
`91`		`- Expires: urlExpiration`
	`91`	`+ Expires: parseInt(urlExpiration)`
`92`	`92`	`})`
`93`	`93`	`}`