git2go: fix reference iterator leak

walken-google · walken-google · commit a2de5abababe · 2018-05-30T14:15:59.000-07:00
This fixes a leak that was apparently introduced in commit 55a1096.
diff --git a/reference.go b/reference.go
@@ -456,10 +456,12 @@ func (v *ReferenceIterator) Next() (*Reference, error) {
 }
 
 func newReferenceIteratorFromC(ptr *C.git_reference_iterator, r *Repository) *ReferenceIterator {
-	return &ReferenceIterator{
+	iter := &ReferenceIterator{
 		ptr:  ptr,
 		repo: r,
 	}
+	runtime.SetFinalizer(iter, (*ReferenceIterator).Free)
+	return iter
 }
 
 // Free the reference iterator

Original file line number	Diff line number	Diff line change
`@@ -456,10 +456,12 @@ func (v ReferenceIterator) Next() (Reference, error) {`
`456`	`456`	`}`
`457`	`457`
`458`	`458`	`func newReferenceIteratorFromC(ptr C.git_reference_iterator, r Repository) *ReferenceIterator {`
`459`		`- return &ReferenceIterator{`
	`459`	`+ iter := &ReferenceIterator{`
`460`	`460`	`ptr: ptr,`
`461`	`461`	`repo: r,`
`462`	`462`	`}`
	`463`	`+ runtime.SetFinalizer(iter, (*ReferenceIterator).Free)`
	`464`	`+ return iter`
`463`	`465`	`}`
`464`	`466`
`465`	`467`	`// Free the reference iterator`