Skip to content

Commit 53c08d5

Browse files
committed
Disable ZRANGESTORE with binary keys.
Seems something is off in Redis' that causes a Redis crash. Closes spring-projects#2441
1 parent ccdd5d2 commit 53c08d5

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/test/java/org/springframework/data/redis/core/DefaultReactiveZSetOperationsIntegrationTests.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
import static org.assertj.core.api.Assertions.*;
1919
import static org.assertj.core.api.Assumptions.*;
2020

21-
import reactor.test.StepVerifier;
22-
2321
import java.time.Duration;
2422
import java.util.Arrays;
2523
import java.util.Collection;
@@ -28,7 +26,6 @@
2826

2927
import org.junit.jupiter.api.BeforeEach;
3028
import org.junit.jupiter.api.Disabled;
31-
3229
import org.springframework.data.domain.Range;
3330
import org.springframework.data.redis.ByteBufferObjectFactory;
3431
import org.springframework.data.redis.ObjectFactory;
@@ -44,6 +41,8 @@
4441
import org.springframework.data.redis.test.extension.parametrized.MethodSource;
4542
import org.springframework.data.redis.test.extension.parametrized.ParameterizedRedisTest;
4643

44+
import reactor.test.StepVerifier;
45+
4746
/**
4847
* Integration tests for {@link DefaultReactiveZSetOperations}.
4948
*
@@ -441,6 +440,7 @@ void rangeAndStoreByLex() {
441440
}
442441

443442
@ParameterizedRedisTest // GH-2345
443+
@Disabled("https://github.com/spring-projects/spring-data-redis/issues/2441")
444444
void rangeAndStoreByScore() {
445445

446446
assumeThat(valueFactory instanceof ByteBufferObjectFactory).isFalse();
@@ -486,6 +486,7 @@ void reverseRangeAndStoreByLex() {
486486
}
487487

488488
@ParameterizedRedisTest // GH-2345
489+
@Disabled("https://github.com/spring-projects/spring-data-redis/issues/2441")
489490
void reverseRangeAndStoreByScore() {
490491

491492
assumeThat(valueFactory instanceof ByteBufferObjectFactory).isFalse();

src/test/java/org/springframework/data/redis/support/collections/AbstractRedisZSetTestIntegration.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
import org.assertj.core.data.Offset;
3030
import org.junit.jupiter.api.BeforeEach;
31-
31+
import org.junit.jupiter.api.Disabled;
3232
import org.springframework.data.domain.Range;
3333
import org.springframework.data.redis.DoubleAsStringObjectFactory;
3434
import org.springframework.data.redis.DoubleObjectFactory;
@@ -610,6 +610,7 @@ void testRangeAndStoreRevByLex() {
610610
}
611611

612612
@ParameterizedRedisTest // GH-2345
613+
@Disabled("https://github.com/spring-projects/spring-data-redis/issues/2441")
613614
void testRangeAndStoreByScore() {
614615

615616
T t1 = getT();
@@ -625,6 +626,7 @@ void testRangeAndStoreByScore() {
625626
}
626627

627628
@ParameterizedRedisTest // GH-2345
629+
@Disabled("https://github.com/spring-projects/spring-data-redis/issues/2441")
628630
void testRangeAndStoreRevByScore() {
629631

630632
T t1 = getT();

0 commit comments

Comments
 (0)