[discovery] createEnv with size 0 for Issue watson-developer-cloud#461 (watson-developer-cloud#463)

Discovery createEnv with size 0
Fixes watson-developer-cloud#461
[semver patch]

Author: alex-thewsey-ibm

discovery/v1.js

@@ -80,8 +80,8 @@ DiscoveryV1.prototype.getEnvironments = function(params, callback) {
 DiscoveryV1.prototype.createEnvironment = function(params, callback) {
   params = params || {};
 
-  // size is an int of 1,2,3, default 1
-  if (!params.size) {
+  // size is an int of 0,1,2,3, default 1
+  if (typeof params.size === 'undefined' || params.size === null) {
     params.size = 1;
   }
 

test/unit/test.discovery.v1.js

@@ -111,6 +111,33 @@ describe('discovery-v1', function() {
           assert.equal(req.method, 'POST');
         });
 
+        it('should create an environment with size 1 by default', function() {
+          const req = discovery.createEnvironment(
+            {
+              name: 'new environment',
+              description: 'my description'
+            },
+            noop
+          );
+          const jsonBodyParts = readMultipartReqJsons(req);
+          assert.equal(jsonBodyParts.length, 1);
+          assert.equal(jsonBodyParts[0].size, 1);
+        });
+
+        it('should create an environment with size 0', function() {
+          const req = discovery.createEnvironment(
+            {
+              name: 'new environment',
+              description: 'my description',
+              size: 0
+            },
+            noop
+          );
+          const jsonBodyParts = readMultipartReqJsons(req);
+          assert.equal(jsonBodyParts.length, 1);
+          assert.equal(jsonBodyParts[0].size, 0);
+        });
+
         it('should update an environment', function() {
           const req = discovery.updateEnvironment(
             {
@@ -265,6 +292,26 @@ describe('discovery-v1', function() {
           );
           assert.equal(req.method, 'GET');
         });
+
+        /**
+         * Return an array of parsed objects representing all valid JSON parts of a multipart request.
+         * @param {*} req 
+         * @return {Array}
+         */
+        function readMultipartReqJsons(req) {
+          const result = [];
+          if (req && req.body && req.body.length) {
+            req.body.forEach(part => {
+              try {
+                result.push(JSON.parse(Buffer.from(part).toString('ascii')));
+              } catch (err) {
+                // JSON parse error -> this part is not JSON: skip.
+              }
+            });
+          }
+
+          return result;
+        }
       });
     });
   });