Skip to content

Commit 5da60bf

Browse files
committed
Fix potential self XSS in request url.
1 parent ec81d25 commit 5da60bf

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

dist/swagger-ui.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1810,7 +1810,8 @@ helpers = this.merge(helpers, Handlebars.helpers); data = data || {};
18101810
}
18111811
}
18121812
this.invocationUrl = this.model.supportHeaderParams() ? (headerParams = this.model.getHeaderParams(map), this.model.urlify(map, false)) : this.model.urlify(map, true);
1813-
$(".request_url", $(this.el)).html("<pre>" + this.invocationUrl + "</pre>");
1813+
$(".request_url", $(this.el)).html("<pre></pre>");
1814+
$(".request_url pre", $(this.el)).text(this.invocationUrl);
18141815
obj = {
18151816
type: this.model.method,
18161817
url: this.invocationUrl,
@@ -2006,7 +2007,8 @@ helpers = this.merge(helpers, Handlebars.helpers); data = data || {};
20062007
pre = $('<pre class="json" />').append(code);
20072008
}
20082009
response_body = pre;
2009-
$(".request_url", $(this.el)).html("<pre>" + url + "</pre>");
2010+
$(".request_url", $(this.el)).html("<pre></pre>");
2011+
$(".request_url pre", $(this.el)).text(url);
20102012
$(".response_code", $(this.el)).html("<pre>" + response.status + "</pre>");
20112013
$(".response_body", $(this.el)).html(response_body);
20122014
$(".response_headers", $(this.el)).html("<pre>" + _.escape(JSON.stringify(response.headers, null, " ")).replace(/\n/g, "<br>") + "</pre>");

dist/swagger-ui.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main/coffeescript/view/OperationView.coffee

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,9 @@ class OperationView extends Backbone.View
186186
else
187187
@model.urlify(map, true)
188188

189-
$(".request_url", $(@el)).html "<pre>" + @invocationUrl + "</pre>"
190-
189+
$(".request_url", $(@el)).html("<pre></pre>")
190+
$(".request_url pre", $(@el)).text(@invocationUrl);
191+
191192
obj =
192193
type: @model.method
193194
url: @invocationUrl
@@ -356,7 +357,8 @@ class OperationView extends Backbone.View
356357
pre = $('<pre class="json" />').append(code)
357358

358359
response_body = pre
359-
$(".request_url", $(@el)).html "<pre>" + url + "</pre>"
360+
$(".request_url", $(@el)).html("<pre></pre>")
361+
$(".request_url pre", $(@el)).text(url);
360362
$(".response_code", $(@el)).html "<pre>" + response.status + "</pre>"
361363
$(".response_body", $(@el)).html response_body
362364
$(".response_headers", $(@el)).html "<pre>" + _.escape(JSON.stringify(response.headers, null, " ")).replace(/\n/g, "<br>") + "</pre>"

0 commit comments

Comments
 (0)